search

tdreyno / middleman-blog-editor-issues

Public bug tracker for middleman-blog-editor gem
http://middleman-blog-editor.awardwinningfjords.com
3 stars 0 forks source link

Unpublished Flag Not Working #3

Closed nayefc closed 11 years ago

nayefc commented 11 years ago

When marking an article as unpublished, it appears on my blog.

tdreyno commented 11 years ago

Is this during preview only or build as well?

Can you paste the "frontmatter" of the article file (on disk, not through the blog editor)? The frontmatter is the stuff at the top between the --- lines.

nayefc commented 11 years ago

That is during build and preview as well. The top lines are:

title: Test Article published: false

blog_editor_id: 8

Nayef Copty nrcopty@gmail.com http://nayefcopty.com

On Thursday, April 11, 2013 at 12:41, Thomas Reynolds wrote:

Is this during preview only or build as well? Can you paste the "frontmatter" of the article file (on disk, not through the blog editor)? The frontmatter is the stuff at the top between the --- lines.

— Reply to this email directly or view it on GitHub (https://github.com/tdreyno/middleman-blog-editor-issues/issues/3#issuecomment-16246439).

tdreyno commented 11 years ago

Preview mode shows unpublished articles so you can develop them, but they shouldn't be built when running middleman build. Looks like the blog editor is correctly setting published: false, so this may be a middleman-blog bug.

What version of middleman-blog are you running?

nayefc commented 11 years ago

I'm running middleman-blog version 3.2.0. Does it have an issue when setting the published flag as false? Isn't this the latest version of middleman-blog?

Nayef Copty nrcopty@gmail.com http://nayefcopty.com

On Friday, April 12, 2013 at 14:57, Thomas Reynolds wrote:

Preview mode shows unpublished articles so you can develop them, but they shouldn't be built when running middleman build. Looks like the blog editor is correctly setting published: false, so this may be a middleman-blog bug. What version of middleman-blog are you running?

— Reply to this email directly or view it on GitHub (https://github.com/tdreyno/middleman-blog-editor-issues/issues/3#issuecomment-16311002).

tdreyno commented 11 years ago

I can't replicate this issue with the same versions.

I have one idea though, was the article formerly built and now, after changing the check box, it's still in the output build/ folder?

If so, Middleman doesn't remove files from build that no longer exist (or are unpublished) by default. Use the --clean flag to change this behavior:

middleman build --clean

If your built article existed in build before, it will now be removed if it is unpublished.

nayefc commented 11 years ago

I have live reload on. Could that be the issue?

I cannot find the article in /build, so I have no idea how it's appearing on localhost:4567/blog. I did a clean build and it said everything was identical. Yet I can see the unpublished article in /blog.

Nayef Copty nrcopty@gmail.com http://nayefcopty.com

On Friday, April 12, 2013 at 18:23, Thomas Reynolds wrote:

I can't replicate this issue with the same versions. I have one idea though, was the article formerly built and now, after changing the check box, it's still in the output build/ folder? If so, Middleman doesn't remove files from build that no longer exist (or are unpublished) by default. Use the --clean flag to change this behavior: middleman build --clean
If your built article existed in build before, it will now be removed if it is unpublished.

— Reply to this email directly or view it on GitHub (https://github.com/tdreyno/middleman-blog-editor-issues/issues/3#issuecomment-16320799).

tdreyno commented 11 years ago

Sounds like everything is working as expected. To reiterate:

Unpublished article are supposed to be visible in preview (localhost:4567), but they will not be built into build.