search

tdryer / hangups

the first third-party instant messaging client for Google Hangouts
https://hangups.readthedocs.io/
MIT License
1.71k stars 189 forks source link

Notifications in dunst stick and don't timeout #483

Open marcusorjames opened 5 years ago

marcusorjames commented 5 years ago

I'm not sure if this is specifically a dunst issue or for any notification system, but my chat notifications never timeout. The urgency seems to be set to normal which is fine and my timeout is set to 4 seconds, which all other normal urgency notifications abide by. Hangups just sticks forever until I open hangups and the message marks as read.

Happy for this to be a flag, if the default behaviour is for it to stick until read.

Thanks for an otherwise fantastic application.

Running Ubuntu 18.04, Dunst 1.3.0

tdryer commented 5 years ago

Currently hangups is setting the timeout to -1. According to the spec this means:

the notification's expiration time is dependent on the notification server's settings, and may vary for the type of notification.

We could certainly add a flag for this.

marcusorjames commented 5 years ago

Interesting, so if that's the case then it should be abiding by my settings, but this is not what I am seeing. I'm not sure setting a flag is a good idea, it might just be my environment ignoring the -1.

Terrance commented 5 years ago

https://github.com/tdryer/hangups/blob/91455286d62f69d94117a89313e95d99939bd0be/hangups/ui/notifier.py#L64

Is the leading space in that argument intentional? Might it be causing DBus to parse it badly?

tdryer commented 5 years ago

The leading space is required for some reason. According to dbus-monitor the value is parsed correctly.