Improve OSX install - Githubissues

tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)

Other

377 stars 101 forks source link

Improve OSX install #199

Closed cstork closed 5 years ago

cstork commented 5 years ago

@juliogonzalez Hi, this is my try. It goes a bit further than your pull request #198 e.g. I noticed that the instruction of how to start the Postgres Server don't apply to macOS. So I fixed that, too.

At first, I considered OS detection in the Makefile, but that actually didn't solve our underlying problem in case other package managers (MacPorts,...) are used. So I left that for when it's needed.

Fixes #197

jenkins-juliogonzalez commented 5 years ago

Can one of the admins verify this patch?

juliogonzalez commented 5 years ago

Test this, please

jenkins-juliogonzalez commented 5 years ago

Test PASSed.

cstork commented 5 years ago

@juliogonzalez I agree with all your comments. Fixes coming...

GeoffMontee commented 5 years ago

Thanks for the contribution!