search

tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)
Other
377 stars 101 forks source link

Fix import schema with no table check, no tested yet #222

Closed jcarnu closed 4 years ago

jcarnu commented 4 years ago

Simple fix for no table in schema error found in #219 and #210. WIP on sys/information_schema extract for columns and views/tables. (will create another branch)

jcarnu commented 4 years ago

Test this please

jenkins-juliogonzalez commented 4 years ago

Test PASSed.

jenkins-juliogonzalez commented 4 years ago

Test PASSed.

juliogonzalez commented 4 years ago

JFYI: As I added you to the whitelist for the tests, you don't really need to use the magic comment when submitting the PR, when pushing new commits to a PR, or when pushing an amended commit to a PR.

juliogonzalez commented 4 years ago

@jcarnu what's the status of the PR?

jcarnu commented 4 years ago

Hey, sorry I'm afk at the moment. I'm quite busy till mid December. Hope i could get time to check it. It's been a while, sorry. End of year are quite pressured at work here.

jcarnu commented 4 years ago

Reading my patch reminds me some things. Patch is okaye. We do not have any test case. OTOH, is it necessary to test this ?

juliogonzalez commented 4 years ago

I am not 100% sure.

If I understand the patch correctly, this is going to provoke a failure, which is not supported right now by the tests scripts (we should probably add it at some point).

If that's the case, I'd say we can merge the PR as it is, but we should open an issue to allow tests that provoke errors and treat them as passed.

GeoffMontee commented 4 years ago

If that's the case, I'd say we can merge the PR as it is, but we should open an issue to allow tests that provoke errors and treat them as passed.

OK, I merged this PR and I created #235 about the missing test.