Closed mattiamarzo closed 4 years ago
Can one of the admins verify this patch?
It's ok to make the pull request from a branch on my repo different from "master", or should I merge on my repo and then submit the pull request from master to master?
Not only OK, but recommended. What you just did is a "feature branch" :-)
I will use the instructions to quickly setup a docker container and see if I can see the same problem you are suffering at #230 (and then merge if the problem is unrelated to the instructions).
I am quite new to git world.
It's ok to make the pull request from a branch on my repo different from "master", or should I merge on my repo and then submit the pull request from master to master?