tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)

Other

377 stars 101 forks source link

Extend Import Foreign Schema to Views #233

Closed pgssimon closed 4 years ago

pgssimon commented 4 years ago

From Feature Request #178

jenkins-juliogonzalez commented 4 years ago

Can one of the admins verify this patch?

juliogonzalez commented 4 years ago

@jenkins-juliogonzalez test this, please

This will see if current tests are not failing, can you add tests to check that feature works? It's important not only to validate this PR, but also to validate that future PRs don't break the feature.

We just recently documented the how to add/modify tests: https://github.com/tds-fdw/tds_fdw/blob/master/tests/README.md#adding-or-modifying-tests

jenkins-juliogonzalez commented 4 years ago

Test PASSed.

juliogonzalez commented 4 years ago

@pgssimon can you add the tests to import a view?

pgssimon commented 4 years ago

Just a bit pushed for time currently, will try to add test this week or next.

thomasfedb commented 4 years ago

Very keen for this change, the MSSQL databases we work with are almost entirely views

juliogonzalez commented 4 years ago

@pgssimon any news? :-)

juliogonzalez commented 4 years ago

BTW: There's a readme now about the tests: https://github.com/tds-fdw/tds_fdw/blob/master/tests/README.md :-)

juliogonzalez commented 4 years ago

Superseded by #248

GeoffMontee commented 4 years ago

248 was just merged. Sorry for the delay!