search

tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)
Other
377 stars 101 forks source link

404 Not Found on WGET of v2.0.0-alpha.3.gz #241

Closed ZFlyGuy closed 4 years ago

ZFlyGuy commented 4 years ago

Hello.

Following the instructions for Ubuntu 18.04, and getting a 404 Not Found on this step:

wget https://github.com/tds-fdw/tds_fdw/archive/${TDS_FDW_VERSION}.gz

Have tried substituting the file name as well, same result, and have tried with 2.0.1 just to see.

juliogonzalez commented 4 years ago

It's a typo, it should be .tar.gz instead of .gz. Can you submit a PR to fix it?

ZFlyGuy commented 4 years ago

i dont know if I can create a branch.. ?

juliogonzalez commented 4 years ago

You just need to fork the repository, then create a branch on your forked repository, do the changes, commit, push and create a PR :-)

ZFlyGuy commented 4 years ago

Should be there now

ZFlyGuy commented 4 years ago

hmm.. not showing up

ZFlyGuy commented 4 years ago

My repository not visible.. think i need to submit pull request directly from edits to the doc itself, creating a branch in this repository.

juliogonzalez commented 4 years ago

No, the doc is part of the repository itself, and therefore it can be edited from a branch on a forked repository.

Have a look at https://help.github.com/en/github/getting-started-with-github/fork-a-repo

ZFlyGuy commented 4 years ago

Just edited directly and its showing as pull request now. However when I edited on forked repository it was only showing there as a pull request. Quite likely I selected something incorrectly when creating request within the forked repository. Looks okay now though I think here. Thank you Julio

juliogonzalez commented 4 years ago

Ah, right, it's also possible doing that. As I never edit from WebUI, didn't remember about that :-)

PR merged. Thanks for the contribution!