search

tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)
Other
377 stars 101 forks source link

Extend Import Foreign Schema to Views #248

Closed juliogonzalez closed 4 years ago

juliogonzalez commented 4 years ago

Fixes #178

Replaces #233 as this PR adds tests on top.

jenkins-juliogonzalez commented 4 years ago

Test FAILed.

juliogonzalez commented 4 years ago

Ok, funny fact: the test passes in all cases except for PostgreSQL 9.4

jenkins-juliogonzalez commented 4 years ago

Test FAILed.

juliogonzalez commented 4 years ago

Ah... of course: https://github.com/tds-fdw/tds_fdw/pull/91#issuecomment-244392844

IMPORT FOREIGN SCHEMA is only available for PostgreSQL >= 9.5

And for reference in the future: https://www.postgresql.org/docs/9.5/sql-importforeignschema.html (there's no doc for <= 9.5)

jenkins-juliogonzalez commented 4 years ago

Test PASSed.

juliogonzalez commented 4 years ago

Ping @GeoffMontee :-)

GeoffMontee commented 4 years ago

Thanks, @juliogonzalez! Sorry for overlooking this one.