search

tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)
Other
381 stars 102 forks source link

Do not pass dummy relabeling to foreign server #290

Closed brunoenten closed 2 years ago

brunoenten commented 3 years ago

Dummy relabeling seems to be an internal postgres mechanism to handle casting between two binary-compatible datatypes.

I ran into an issue while using a condition on a varchar column coerced to text.

Without this fix, this postgres query SELECT ... FROM ... WHERE this_col_is_a_varchar::text ~~ 'burp%';

generates something like

SELECT ... FROM ... WHERE this_vol_is_a_varchar as text like 'burp%';

which triggers a syntax error. I'm pretty sure passing this relabeling mechanism along is not necessary.

See https://github.com/postgres/postgres/blob/845cad4d51cb12a34ea012dfe58af5ef490384fc/src/include/nodes/primnodes.h#L837

jenkins-juliogonzalez commented 3 years ago

Can one of the admins verify this patch?

GeoffMontee commented 3 years ago

Test this, please

juliogonzalez commented 3 years ago

mmm... the webhook looks OK, but nothing was launched.

Test this, please

?

juliogonzalez commented 3 years ago

Looks to me that something is broken after the last Jenkins update. I see the comments being detected, but no job is being launched.

Will review it later.

juliogonzalez commented 3 years ago

Ah, it's just delayed :-?

Strange.

jenkins-juliogonzalez commented 3 years ago

Test PASSed.

brunoenten commented 3 years ago

As everything is green, could a maintener please merge the PR?

GeoffMontee commented 2 years ago

Sorry for the delay, @brunoenten. This PR has been merged. Thanks!