Add support for user-defined data types (Sybase only)

tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)

Other

377 stars 101 forks source link

Open vitalca opened 1 year ago

vitalca commented 1 year ago

Related issue: #323

jenkins-juliogonzalez commented 1 year ago

Can one of the admins verify this patch?

GeoffMontee commented 1 year ago

Test this, please

jenkins-juliogonzalez commented 1 year ago

Test PASSed.

juliogonzalez commented 1 year ago

Let's test it again, and if so, maybe it can be merged.

Test this, please.

jenkins-juliogonzalez commented 1 year ago

Test PASSed.

GeoffMontee commented 1 year ago

Hi @vitalca ,

Thanks for the PR! Sorry for letting this one sit for a while.

What do you think about the following changes for this?:

Allow different foreign servers to have different keep_untranslatable_types values by changing it from a custom boolean variable to a server option defined in src/options.c
Add some documentation for keep_untranslatable_types to ForeignServerCreation.md

vitalca commented 1 year ago

Hi @GeoffMontee,

That makes sense. Thanks for the suggestion! I am a Java developer, but what you suggested is seemingly easy to implement. Let me give it a try.