tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)
Other
377 stars 101 forks source link

add upgrade route from 2.0.1 to 2.0.3 #339

Closed kav23alex closed 1 year ago

kav23alex commented 1 year ago

Fix for the ability to upgrade from version 2.0.1 to 2.0.3 Update from version 1.0.0 intentionally skipped

jenkins-juliogonzalez commented 1 year ago

Can one of the admins verify this patch?

jcarnu commented 1 year ago

test this please

Le jeu. 28 sept. 2023 à 06:41, Jenkins Bot @.***> a écrit :

Can one of the admins verify this patch?

— Reply to this email directly, view it on GitHub https://github.com/tds-fdw/tds_fdw/pull/339#issuecomment-1738421698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5UH4MUKAQEMV62EGON3TX4T5WTANCNFSM6AAAAAA5KLGHGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jean-Christophe Arnu

GeoffMontee commented 1 year ago

Test this, please

jenkins-juliogonzalez commented 1 year ago

Test PASSed.

GeoffMontee commented 1 year ago

Hi @kav23alex,

I just took a look at the upgrade script for postgres_fdw, and it has some lines like this:

-- complain if script is sourced in psql, rather than via ALTER EXTENSION
\echo Use "ALTER EXTENSION postgres_fdw UPDATE TO '1.1'" to load this file. \quit`

See here: https://github.com/postgres/postgres/blob/REL_16_0/contrib/postgres_fdw/postgres_fdw--1.0--1.1.sql#L3

Maybe it would make sense to add similar lines to the tds_fdw upgrade scripts? e.g.:

-- complain if script is sourced in psql, rather than via ALTER EXTENSION
\echo Use "ALTER EXTENSION tds_fdw UPDATE TO '2.0.3'" to load this file. \quit

What do you think?

kav23alex commented 1 year ago

@GeoffMontee, Thank you, fixed it.

GeoffMontee commented 1 year ago

Thank you!

Test this, please

jenkins-juliogonzalez commented 1 year ago

Test PASSed.

GeoffMontee commented 1 year ago

This PR has been merged. Thank you!!