search

tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)
Other
357 stars 99 forks source link

Introduce new server option ansi_mode. #348

Closed psoo closed 7 months ago

psoo commented 7 months ago

Follow up PR for https://github.com/tds-fdw/tds_fdw/pull/347 with suggested changes, squashed commits.

jenkins-juliogonzalez commented 7 months ago

Can one of the admins verify this patch?

GeoffMontee commented 7 months ago

Test this, please

jenkins-juliogonzalez commented 7 months ago

Test PASSed.

GeoffMontee commented 7 months ago

Hi @psoo,

Thanks for the squashed patch! It looks like the tdsSetSqlServerAnsiMode() function has two declarations:

/*
 * Internal helper to set ANSI compatible server-side settings for SQL Server
 * in case foreign server was configured with sqlserver_ansi_mode 'true'.
 */
static void tdsSetSqlServerAnsiMode(DBPROCESS **dbproc);

/*
 * Internal helper to set ANSI compatible server-side settings for SQL Server
 * in case foreign server was configured with sqlserver_ansi_mode 'true'.
 */
static void tdsSetSqlServerAnsiMode(DBPROCESS **dbproc);

Shouldn't one of these be removed? If you fix this issue, then I will merge the patch.

Thanks!

psoo commented 7 months ago

Oh yes, looks like a copy&past mistake...sorry for this, didn't see this before pushing. Fixed.

GeoffMontee commented 7 months ago

Test this, please

jenkins-juliogonzalez commented 7 months ago

Test PASSed.

GeoffMontee commented 7 months ago

This has been merged. Thanks again for the patch!