search

tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)
Other
357 stars 99 forks source link

Update create_foreignscan_path parameters for PostgreSQL commit 9e9931d2bf #358

Closed esiaero closed 4 weeks ago

esiaero commented 4 weeks ago

Hi, Postgres 17 Beta1 is out and I noticed tds_fdw doesn't build with it due to the change mentioned in the title, so I thought I'd submit a PR for it.

(Following is the commit message)

The upstream commit adds a new argument to create_foreignscan_path [1]. tds_fdw doesn't currently replace joins, so nothing is passed to the new argument.

[1] https://github.com/postgres/postgres/commit/9e9931d2bf

jenkins-juliogonzalez commented 4 weeks ago

Can one of the admins verify this patch?

GeoffMontee commented 4 weeks ago

Test this, please

jenkins-juliogonzalez commented 4 weeks ago

Test PASSed.

GeoffMontee commented 4 weeks ago

Hi @esiaero ,

Thanks for the patch! This has been merged.