tds-fdw / tds_fdw

A PostgreSQL foreign data wrapper to connect to TDS databases (Sybase and Microsoft SQL Server)
Other
381 stars 102 forks source link

Fix problem with exceptions on tests: use postgres attributes only if available #65

Closed juliogonzalez closed 8 years ago

juliogonzalez commented 8 years ago

There was a problem in the way we caught exceptions at the test scripts, as postgres error attributes were used even when it was not possible (therefore masking exceptions).

See example at https://jenkins.juliogonzalez.es/job/tds_fdw-build/PG_VER=9.5,label=centos6/159/console

Now we show postgres error attributes if available, or just the error otherwise.

Tested at https://jenkins.juliogonzalez.es/job/tds_fdw-build-ng/PG_VER=9.5,label=centos6/1/console

GeoffMontee commented 8 years ago

Thanks for fixing that! Would you like me to grant you the privileges to push to the repo?