Closed juliogonzalez closed 8 years ago
Ok, BOT seems to be working fine as it started running tests for this PR :-)
Fine. Let's try to break the PR :-)
Ok, all comments were being used to trigger tests as long as the comment was being issued by an admin. Changed now to use a trigger.
Checking the trigger...
Retest this please
Testing config again...
And again... The bot should be ignorning my comments unless the passphrase is present.
Testing...
Test FAILed.
Bot installed
test this please
Test PASSed.
Testing comments...
Interesting.... bot is installed but the job still uses my credentials. I just tried reconfiguring the job. If that doesn't work I'll need to reboot Jenkins.
retest this please
Test FAILed.
retest this please
Test PASSed.
Test FAILed.
Fine!
@GeoffMontee, could you please trigger the bot to see if your rights are correctly configured at Jenkins?
Just write a comment with the same content as my last comment before the last "Test passed".
After this I'll test this for "external users". They should be able to run create PRs, but tests shouldn't run automatically. In this case either you or me will issue a comment to trigger tests after reviewing and before merging.
retest this please
Test FAILed.
Great :-D
Final step is to test a PR from an external user (not a project member). After I confirm that it's working as expected, I'll write a small manual on how to use this, so you can see how it works (maybe you'll even start creating your own PRs :-)
Awesome. Thanks, @juliogonzalez! This PR webhook seems really useful!
Tests are complete. Closing PR.
Just a Test PR for Jenkins PR Builder.
@GeoffMontee, do not merge this PR as it's just for testing.