search

tdscott10 / Tetris

SER216 Final Project
0 stars 0 forks source link

Tiletype.java exit points #18

Closed ghost closed 8 years ago

ghost commented 8 years ago

Line 354, 375, 396, 417: multiple exit points found, a method should have only one and it should be the last statement in the method.

ghost commented 8 years ago

Looking through this particular bug, I think the code is simple and more readable the way it is. If we refactor it to maintain the single exit point entry for each of the Insets the code would be far more complex. (I did refactor the clock.java hasElapsedCycle method for the single entry as it was a boolean method and the refactor was really simple and the code easy to read.)