search

tdsmith / homebrew-pypi-poet

Generates Homebrew resource stanzas for Python packages.
MIT License
140 stars 30 forks source link

consider wheels #42

Closed Kriechi closed 7 years ago

Kriechi commented 7 years ago

Many pypi packages only uploaded wheels, which poet doesn't consider. This PR makes a small change to also accept wheels as artifact.

fixes #29

tdsmith commented 7 years ago

Can you give an example of a package that doesn't distribute an sdist? I don't think there are "many".

tdsmith commented 7 years ago

This isn't sufficient to resolve #29; some packages have entries on pypi but no uploaded distributions.

Kriechi commented 7 years ago

I'm one of the @mitmproxy maintainers, and we only ship wheels, because otherwise we run into problems with Python2 installations.

So I know of mitmproxy and one of our dependencies: construct.

jbarlow83 commented 7 years ago

Python wheels should be the first choice and sdist should be the fallback.

Why not consider macOS binary wheels? People regularly install Homebrew and pip binaries.

tdsmith commented 7 years ago

Why not consider macOS binary wheels?

Homebrew policy (and therefore poet's policy) is to build from source.

Pure-python wheels are technically a distribution format and not a source format but the distinction feels less important and it might simplify things at some future point where setuptools is less dominant so I feel less strongly about it.