search

tdsmith / homebrew-pypi-poet

Generates Homebrew resource stanzas for Python packages.
MIT License
140 stars 30 forks source link

Packages in private pip repositories are not supported #55

Closed dzavalkinolx closed 7 years ago

dzavalkinolx commented 7 years ago

I have a private package hosted in our company's artifactory. I have a extra-index-url set in my pip config but homebrew-pypi-poet doesn't respect extra-index-url. It just has a hardcoded package resolution to https://pypi.io/pypi/{}/json in https://github.com/tdsmith/homebrew-pypi-poet/blob/master/poet/poet.py#L80.

tdsmith commented 7 years ago

Thanks for opening an issue. That sounds right; there's no attempt to interpret pip's configuration. The goal of this project is to facilitate contributions to the public Homebrew repositories and so pypi is the only package repository in scope.

dzavalkinolx commented 7 years ago

What's wrong with having private homebrew repositories and why you don't wish to support them? I understand that in the end this is your tool and you can do whatever you want of course... But since it is linked on the Homebrew tools for python developers page and Homebrew team has nothing against creating private taps I don't see why officially suggested tool for generating formula resources shouldn't support private pip packages...

tdsmith commented 7 years ago

What's wrong with having private homebrew repositories

Nothing at all. It's just a distinct set of problems that I don't personally have. It also seems to arise mostly in contexts where people who aren't me are being paid to work on things :) and my personal preference is to not spend much of my OSS time in that space.

americanhanko commented 4 years ago

My company is also having this problem. Artifactory's Python package data is formatted in XML, but return roughly the same information about the packages as the data stored in JSON by PyPI. I'm not sure it would be that difficult to support a custom PyPI URL – @tdsmith would you be willing to merge a pull request if this feature was added? CC: @dzavalkinolx

tdsmith commented 4 years ago

No, but please feel free to fork.