change div.clickable to a[href]

tdt / core

Transform any dataset into an HTTP API with The DataTank

http://thedatatank.com

83 stars 31 forks source link

Closed Haroenv closed 7 years ago

Haroenv commented 8 years ago

There are no other occurences of data-href in the whole project

closes #409

fixes #398

thgh commented 8 years ago

There are still some issues:

[ ] Merge conflict in home.blade.php, this is because the homepage uses Vue.js for facet filtering, the clickable-row to replace is now in Dataset.vue. Run gulp to compile the js.
[ ] The clickable-row in the admin is not replaceable because it contains other links, <a> cannot be nested.
[ ] The titles of the rows are links. These links have to be removed, also because it's not nestable.

Haroenv commented 8 years ago

I just noticed that I'm impossibly far behind on upstream, I'll delete this and try again later.