improved coverage with new tests

tducret / amazon-scraper-python

Non-official client to get some info about products sold on Amazon

MIT License

871 stars 159 forks source link

improved coverage with new tests #13

Closed sdolenc closed 5 years ago

sdolenc commented 5 years ago

The coverage percentage can be improved with ~~three~~ four new, simple tests.

Additional thoughts.

test runtime can be reduced by moving changing _MAX_TRIAL_REQUESTS into a default parameter =5. That'll allow the tests to specify 2 attempts.
most of _get_products can be skipped if valid_page stays false

Let me know if you'd like me to make any of the above changes as part of this pull request. I'm also happy to incorporate other suggestions too

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 175

44 of 44 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+7.1%) to 98.701%

Totals
Change from base Build 165:	7.1%
Covered Lines:	152
Relevant Lines:	154

💛 - Coveralls

tducret commented 5 years ago

Very nice of you @sdolenc I'll try to merge it soon. Feel free to implement your other ideas. I'm not sure I really understand the first one though.

sdolenc commented 5 years ago

Cool. My next commit on this pull request will include my second idea.

Sorry I didn't explain the first idea very clearly. It should speed up the time it takes to run the new tests. I'll submit it in a separate pull request for your consideration.

Hope you and your family are having a Merry Christmas!