search

tdulcet / Thunderbird-Send

📤 FileLink provider for Send (formerly Firefox Send)
https://addons.thunderbird.net/thunderbird/addon/filelink-provider-for-send/
Mozilla Public License 2.0
42 stars 8 forks source link

unusable in darkmode #12

Open sn55997 opened 2 months ago

sn55997 commented 2 months ago

Cant read the add-on window in thunderbird's darkmode image

tdulcet commented 2 months ago

Thanks for the bug report. The regular dark mode works for me: image

I believe the issue is that you also enabled the high contrast mode, which is not yet supported by the library this add-on uses for the CSS. See https://github.com/TinyWebEx/AutomaticSettings/issues/23 for more information.

sn55997 commented 2 months ago

Sorry for the double post and thanks for the quick reply.

High contrast mode is not enabled! BUT: I changed the colours in Preferences>Fonts&Colours as this is the only way to get the message preview window to work in dark mode. This should not affect the options window of any add-on, but it does in some add-ons (e.g. ReplyWithHeader). If the colour preferences are set to default, dark mode works as expected in the FileLink provider for Send. But I do not want the light message preview. (Changing the forced-colours and prefers-contrast tags did not work.) So it does not seem to be caused by your code, but the "FileLink provider for box" e.g. does not have this problem in the Preferences>Compose>Attachments window. Any ideas?

image image image

tdulcet commented 2 months ago

Thanks for the detailed information and screenshots. My understanding is that using that override in Thunderbird has the same effect as enabling high contrast mode, so adding support for high contrast mode should resolve the issue for you. See the discussion in https://github.com/rugk/awesome-emoji-picker/issues/131, where another user had this same issue with an add-on I help maintain.

Note that Thunderbird 128 is scheduled to have support for automatically converting light message content to dark (see bug 1715361), which would allow you to have dark messages without needing to enable this override. Long term, the CSS in the library will need to be updated to support high contrast mode. I do not have the CSS knowledge to make the changes myself (which is why I use a library), so I will leave this issue open until we find a volunteer.

sn55997 commented 2 months ago

Thanks a lot, this was very helpful!