tdvsdv / enhanced_my_page

This plugin allows determine default blocks on my page, and also allows include in my page any queries that common for all project
5 stars 3 forks source link

404 error #2

Open markedagain opened 11 years ago

markedagain commented 11 years ago

i tried troubleshooting what it can be, but my skills are lacking, i simply get a 404 when visiting the page.

Started GET "/my/page" for 69.165.197.4 at 2013-08-20 20:47:28 -0400 Processing by MyController#page as HTML Current user: johndo(id=3) Rendered plugins/redmine_bookmarks/app/views/my/blocks/_bookmarks_box.html.erb (9.5ms) Rendered plugins/enhanced_my_page/app/views/my/page.html.erb within layouts/base (67.3ms) Missing template, responding with 404 Rendered common/error.html.erb within layouts/base (0.4ms) Rendered plugins/redmine_code_review/app/views/code_review/_html_header.html.erb (0.5ms) Rendered plugins/redmine_improved_searchbox/app/views/redmine_improved_searchbox/_redmine_improved_searchbox_partial.html.erb (1.0ms) Rendered plugins/redmine_wiki_extensions/app/views/wiki_extensions/_html_header.html.erb (0.5ms) Rendered plugins/clipboard_image_paste/app/views/clipboard_image_paste/_headers.html.erb (1.1ms) Rendered plugins/sidebar_hide/app/views/sidebar/_hideButton_partial.html.erb (0.8ms) Rendered plugins/chiliproject_message_bar/app/views/message_bars/_bar.html.erb (0.9ms) Rendered plugins/redmine_code_review/app/views/code_review/_body_bottom.html.erb (0.8ms) Rendered plugins/redmine_wiki_extensions/app/views/wiki_extensions/_body_bottom.html.erb (0.5ms) Rendered plugins/clipboard_image_paste/app/views/clipboard_image_paste/_add_form.html.erb (3.0ms) Completed 404 Not Found in 163ms (Views: 71.6ms | ActiveRecord: 2.2ms)

dkuk commented 11 years ago

Too many plugins installed, as I can see. Is problem reproduces only whith enhanced_my_page installed? What is ruby version and Redmine version? Is problem actual for any user?

Also it can be a problems with rendering my page when the structure of preffered queries for user personal page is corrupted or empty (cell of table is absolute clear, but should have at lest empty serialized data). But you will get error 500 in case of corrupted preferences.

markedagain commented 11 years ago

ok, i got it all working by adding <% next unless MyController::BLOCKS.keys.include? b %> on top of each normal block being rendered.

i can try to debug more, but u are right it might be another plugin issue, as i decided to upgrade ruby to 1.9.3

Environment: Redmine version 2.3.2.stable.12119 Ruby version 1.9.3-p429 (2013-05-15) [x86_64-linux] Rails version 3.2.13 Environment production Database adapter Mysql2 Redmine plugins: chiliproject_message_bar 0.1.0 clipboard_image_paste 1.3 enhanced_my_page 0.0.1 issue_hot_buttons 0.4.4 redirect_to_after_login 0.0.2 redmine_add_subversion_links 0.2.0 redmine_charts2 0.2.1 redmine_code_review 0.6.2 redmine_default_assign 0.2.0 redmine_default_version 0.0.2 redmine_didyoumean 1.2.0 redmine_fulmo_helper 1.0.0 redmine_gist 0.0.1 redmine_hudson 2.1.1 redmine_improved_searchbox
redmine_information 1.0.2 redmine_issue_control_panel 0.3.0 redmine_issue_detailed_tabs_time 0.0.7 redmine_people 0.1.6 redmine_plugin_views_revisions 0.0.1 redmine_release_notes 1.3.1-beta redmine_smart_issues_sort 0.3.1 redmine_tab 0.4.0 redmine_theme_changer 0.1.0 redmine_track_control 1.0.8 redmine_user_issues 0.0.2 redmine_wiki_extensions 0.6.3 redmine_work_changes 0.0.1 sidebar_hide 0.0.4 unread_issues 0.0.1 wiking 0.0.3

markedagain commented 11 years ago

btw, im very excited to have gotten this to work ,great work!! going to check out your other plugins. i just got unread issues working, great idea, been trying to get my employees to switch "new" tickets to "open" to keep track of read , but this is soooo much better.

also im not sure if i forked off u or another, but there is a new fork to the detailed_history_tab and it add many more tabs and time logs also

cforce commented 11 years ago

@markedagain did you find out at which plugin this "<% next unless MyController::BLOCKS.keys.include? b %>" was missing. I also have a lot of plugins and wish to fix this issues there also. Would be great if you push fixes for the corresponding github repos.

markedagain commented 11 years ago

hey @cforce let me double check, but it was this plugin that needed to be altered , i did not push my changes cause nobody else was complaining so i figure maybe something wrong with my setup

markedagain commented 11 years ago

ok, rereading your question, you did not ask where i did the fix,

nope, not to sure what plugin is causing the block to give out an error, my simple solution was to redo this block check that the original view did in first place, and that @dkuk decided to remove on his view overwrite.

i had to add <% next unless MyController::BLOCKS.keys.include? b %> to both page.html (13,26,39) and page_layout.html (21,32,43)

if u want i can fork off make my changes and show u , but i did not want to make a pull request, cause im unsure why he left these out in the first place.

markedagain commented 11 years ago

@cforce i forked and pushed my changes, let me know if this fix;s it for u and does not break anything else of this plugin, if its good, ill send the pull request

markedagain commented 11 years ago

ooo also, @cforce i highly recommend his other plugin unread_issues. it puts a green circle image next to issues you have not opened yet. one of my fab plugins atm

dkuk commented 11 years ago

Ok. Let me know plz if you are find a cause of your problem. Could you reproduce the problem again on your data with adding debug strings to log? Change the code from <% next unless MyController::BLOCKS.keys.include? b %> if server runs in development (or change debug to error for production) to: <% unless MyController::BLOCKS.keys.include? b %> <% Rails.logger.debug "\n\n~~~~~~ \n missing_block = #{b.inspect}" %> <% next %> <% end %> And look trough the log for this

cforce commented 11 years ago

The patch https://github.com/markedagain/enhanced_my_page/commit/2dc43a3ab514953d4c45de07fa44bca1f719fe5d removes the 404 problem.

But now i added Query block and see "Query has been removed" placed there. Whats worng now?

cforce commented 11 years ago

@markedagain ciommented ur prorposal to use unread_issues, do you mean https://github.com/tdvsdv/unread_issues.git ?? I already had this, but didin't undertsnad what i does and the layout looks strange. What shall this figures say and why are they without any seperator and explananation? See my screener

image

dkuk commented 11 years ago

It displays green|blue circle near issue in lists. Your screenshot is a part of top menu. First digit - assigned issues (should be dark-green by default), second - new issues (green), last - updated unread (blue) 6

But only one green square is displayed. We point styles in our skin

the styles for is

top-menu a span.unread {

background-color: #C3E26B; }

top-menu a span.updated {

background-color: #76A8D7; }

top-menu li a span.count, #top-menu li a #my_page_issues_count {

border-bottom-width: 0px; } span.count { background-color: #3F7FB1; background-color: #077C10; padding: 0px 4px 0px 4px; position: relative; top: -2px; border-radius: 8px 8px; left: 5px; box-shadow: 0 1px 2px rgba(0, 0, 0, 0.5); font-size: 7.5pt; font-weight: bold; margin-right: 5px; color: #FFF;}

look around http://rmplus.pro and http://demo.rmplus.pro

cforce commented 11 years ago

The problems was the css which is actual inb the github repo. Can un provide ur fix to this, because now it works. my page

cforce commented 11 years ago

However it would be better if every cpoun will link to its correspsoning issue list view, and only mypage links to mypage. https://github.com/tdvsdv/unread_issues/pull/8 This start getting offtopic here ;) What about the bug of this plugin. Will it be fixed?

markedagain commented 11 years ago

missing_block = "bookmarks_box"