tdwg / ac

Audiovisual Core
http://www.tdwg.org/standards/638
Creative Commons Attribution 4.0 International
11 stars 6 forks source link

Table cell boundaries not visible under new website theme #256

Closed baskaufs closed 1 year ago

baskaufs commented 1 year ago

Page(s) where issue occurs

https://ac.tdwg.org/structure/#321-example-of-a-table-with-each-service-access-point-in-a-separate-row-non-normative

Issue description

The current styling of the tables has dropped the cell boundary lines. So it's no longer clear that the example is a table. Not sure if this is something to be fixed on the CSS/theme end or if it should be hard-coded in the Markdown document

peterdesmet commented 1 year ago

I'm moving this issue, as it relates to AC specifically. Will answer there.

peterdesmet commented 1 year ago

The is because that page (and probably others) defines a class for that table (and probably others):

https://github.com/tdwg/ac/blob/8d4196fb42ee35dbe5a22915ca15759e0f8d0d23/docs/structure/index.md?plain=1#L248

table-responsive is a wrong Bootstrap class to use for tables. It should be used for a parent div of the table. Petridish will add those divs automatically, so it's not necessary to do it manually. Petridish will also automatically add the class table to tables unless (as is the case here) a class is already defined.

So the solution would be to change to <table> (and have Petridish add the class table) or hardcode as <table class="table">. My preference is the first, so contributors don't have to worry about adding classes or not. The result will look like this:

Screenshot 2023-05-03 at 16 55 08
baskaufs commented 1 year ago

Thanks @peterdesmet . I'm not sure how that class was added to the table element. Probably just got copied from somewhere. I will fix the tags and see if there are other changes needed in other documents.

baskaufs commented 1 year ago

fixed