tdwg / bdq

Biodiversity Data Quality (BDQ) Interest Group
https://github.com/tdwg/bdq
43 stars 7 forks source link

TG2-VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION #108

Open iDigBioBot opened 6 years ago

iDigBioBot commented 6 years ago
TestField Value
GUID d708526b-6561-438e-aa1a-82cd80b06396
Label VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION
Description Is the value of dwc:minimumElevationInMeters a number less than or equal to the value of dwc:maximumElevationInMeters?
TestType Validation
Darwin Core Class dcterms:Location
Information Elements ActedUpon dwc:minimumElevationInMeters
dwc:maximumElevationInMeters
Information Elements Consulted
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is bdq:Empty, or if either is not a number; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions MINELEVATION_LESSTHAN_MAXELEVATION
Parameter(s)
Source Authority
Specification Last Updated 2023-09-18
Examples [dwc:minimumElevationInMeters="0", dwc:maximumElevationInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:minimumElevationInMeters is equal to dwc: maximumElevationInMeters"]
[dwc:minimumElevationInMeters="1", dwc:maximumElevationInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:minimumElevationInMeters is greater than dwc:maximumElevationInMeters"]
Source @Tasilee
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes
iDigBioBot commented 6 years ago

Comment by Lee Belbin (@Tasilee) migrated from spreadsheet: Validation equivalent to amendment

chicoreus commented 2 years ago

For consistency with #112 and #39 and #24 should probably have internal prerequisites not met if either of the information elements has a value that is not a number.

Propose changing:

INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is EMPTY; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT

To:

INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is EMPTY or either is not a number; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT

ArthurChapman commented 2 years ago

Agree

tucotuco commented 2 years ago

Agree

On Sat, Feb 19, 2022 at 7:28 PM Arthur Chapman @.***> wrote:

Agree

— Reply to this email directly, view it on GitHub https://github.com/tdwg/bdq/issues/108#issuecomment-1046116133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQ725ODWSFJZGJX2YQJKTU4AKRNANCNFSM4EKSRYRA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

Tasilee commented 2 years ago

I agree and have made the change.

Tasilee commented 2 years ago

I note that we have used here "is not a number;" but elsewhere (e.g., #87) we use "interpretable as a number". How do you want to play this? I'd opt for the former (Occam).

Also, I presume the ER would also apply to #24?

tucotuco commented 2 years ago

"is a number" sounds simple even if it might not be as rigorously correct. An example would be for the month field because entomologists use Roman numerals, but we say "is an integer" there, so it seems perfectly reasonable to say "is a number" here.

I'm not sure what you mean by "also apply to #24", but certainly the pattern should be consistent.

Tasilee commented 2 years ago

I have aligned the Expected Response of #24 with this one.

Tasilee commented 1 year ago

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"