search

tdwg / bdq

Biodiversity Data Quality (BDQ) Interest Group
https://github.com/tdwg/bdq
43 stars 7 forks source link

TG2-AMENDMENT_OCCURRENCESTATUS_STANDARDIZED #115

Open godfoder opened 6 years ago

godfoder commented 6 years ago
TestField Value
GUID f8f3a093-042c-47a3-971a-a482aaaf3b75
Label AMENDMENT_OCCURRENCESTATUS_STANDARDIZED
Description Proposes an amendment to the value of dwc:occurrenceStatus using the bdq:sourceAuthority.
TestType Amendment
Darwin Core Class dwc:Occurrence
Information Elements ActedUpon dwc:occurrenceStatus
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:ocurrenceStatus is bdq:Empty; AMENDED the value of dwc:occurrenceStatus if it can be unambiguously interpreted as a value in the bdq:sourceAuthority; otherwise NOT_AMENDED
Data Quality Dimension Conformance
Term-Actions OCCURRENCESTATUS_STANDARDIZED
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "GBIF OccurrenceStatus Vocabulary" [https://api.gbif.org/v1/vocabularies/OccurrenceStatus]} {"dwc:occurrenceStatus vocabulary API" [https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts]}
Specification Last Updated 2024-07-26
Examples [dwc:occurrenceStatus="1": Response.status=AMENDED, Response.result=dwc:occurrenceStatus="present", Response.comment="Input field contains interpretable value. This may be pushing it a little, but I would have interpreted 1/0 as present/absent"]
[dwc:occurrenceStatus="X": Response.status=NOT_AMENDED, Response.result=, Response.comment="Input field contains uninterpretable value "X"]
Source ALA
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes The original recommended controlled vocabulary for this term consisted of "present" and "absent", which are the only two appropriate terms for a Darwin Core Occurrence. This is reflected in the suggested dwc:occurrenceStatus vocabulary for this test. Other values for dwc:occurrenceStatus should only arise under circumstances that do not refer to an Occurrence.
chicoreus commented 5 years ago

Output Type is missing from the Field/Value table. @Tasilee please correct (looks like it should be Output Type = Amendment) and review table for any other errors.

Tasilee commented 5 years ago

Thanks @chicoreus. Done. I don't understand how the Python code dump of the tables actually figured it out anyway!! If it had not, I would have been alerted.

chicoreus commented 5 years ago

@Tasilee thanks for resolving that. The python code you alude to may not be mapping correctly to framework concepts (or it may be trying to extract the typing from the label). Make sure results are compared with those of kurator-org/bdq_issue_to_csv

Tasilee commented 1 year ago

Updated Source Authority to

bdq:sourceAuthority default = {Darwin Core} {[https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] }

Does the link "[https://dwc.tdwg.org/terms/#occurrenceStatus]" need a title? Maybe this...

{Occurrence status [https://dwc.tdwg.org/terms/#occurrenceStatus] } ?

Is this the model we should use elsewhere (#63, #104, #116)?

ArthurChapman commented 1 year ago

How about

bdq:sourceAuthority default = {Darwin Core dwc:occurrenceStatus} {[https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] }

ArthurChapman commented 1 year ago

Although the way you have done it now is OK

chicoreus commented 1 year ago

On Thu, 29 Jun 2023 23:14:46 -0700 Arthur Chapman @.***> wrote:

How about

bdq:sourceAuthority default = {Darwin Core dwc:occurrenceStatus} {[https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] }

That is cleaner, in that it gives a clear text string for implementors to match against.

I'd advocate one step futher, and be explicit about the default value being the string, with the rest of the information being explanatory:

bdq:sourceAuthority default = "Darwin Core dwc:occurrenceStatus" {[https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] }

Tasilee commented 1 year ago

Amended Source Authority values to align with @chicoreus syntax

bdq:sourceAuthority default = {Darwin Core} {Occurrence status [https://dwc.tdwg.org/terms/#occurrenceStatus] } {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] }

to

bdq:sourceAuthority default = "Darwin Core dwc:occurrenceStatus" {[https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] }

Tasilee commented 1 year ago

Post Zoom 11/7/2023, I have aligned the Source Authority with the suggested syntax:

bdq:sourceAuthority default = "Darwin Core dwc:occurrenceStatus" {[https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml] }

to

bdq:sourceAuthority default = "Darwin Core" {https://dwc.tdwg.org} {dwc:occurrenceStatus" [https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml]}

Tasilee commented 1 year ago

Due to recent discussions, changed Source Authority from

bdq:sourceAuthority default = "Darwin Core" {https://dwc.tdwg.org} {dwc:occurrenceStatus" [https://dwc.tdwg.org/terms/#occurrenceStatus]} {Controlled Vocabulary Document [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml]}

to

bdq:sourceAuthority = "Darwin Core occurrenceStatus" {https://dwc.tdwg.org/list/#dwc_occurrenceStatus} {dwc:occurrenceStatus vocabulary [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml]}

and Parameter(s) from

bdq:sourceAuthority

to

dwc:occurrenceStatus vocabulary

We will need some Notes from @tucotuco

tucotuco commented 1 year ago

Replaced

"The reference vocabularies of values for occurrence status need to be developed and published."

in notes with

"The original recommended controlled vocabulary for this term consisted of "present" and "absent", which are the only two appropriate terms for a Darwin Core Occurrence. This is reflected in the suggested dwc:occurrenceStatus vocabulary for this test. Other values for dwc:occurrenceStatus should only arise under circumstances that do not refer to an Occurrence."

Tasilee commented 11 months ago

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"

Tasilee commented 4 months ago

Changed Source Authority from

bdq:sourceAuthority = "Darwin Core occurrenceStatus" {https://dwc.tdwg.org/list/#dwc_occurrenceStatus} {dwc:occurrenceStatus vocabulary [https://rs.gbif.org/vocabulary/gbif/occurrence_status_2020-07-15.xml]}

to

bdq:sourceAuthority default = "GBIF OccurrenceStatus Vocabulary" [https://api.gbif.org/v1/vocabularies/OccurrenceStatus]} {"dwc:occurrenceStatus vocabulary API" [https://api.gbif.org/v1/vocabularies/OccurrenceStatus/concepts]}

chicoreus commented 1 month ago

Removed the parameter, it doesn't apply here.

chicoreus commented 1 month ago

I must have been looking at the wrong test.....

bdq:sourceAuthority probably is needed here. The values in the examples and comment in Darwin Core are "present" and "absent", but the GBIF vocabulary terms that we provide as the default source authority are "Present" and "Absent".

Also dataID 902 in the validation data includes an invalid source authority.

Tasilee commented 1 month ago

Corrected dataID 902 to "absent".

Given @timrobertson100's recent comments, we are presuming alignment with dwc case?