tdwg / bdq

Biodiversity Data Quality (BDQ) Interest Group
https://github.com/tdwg/bdq
43 stars 7 forks source link

TG2-VALIDATION_MINDEPTH_LESSTHAN_MAXDEPTH #24

Open iDigBioBot opened 6 years ago

iDigBioBot commented 6 years ago
TestField Value
GUID 8f1e6e58-544b-4365-a569-fb781341644e
Label VALIDATION_MINDEPTH_LESSTHAN_MAXDEPTH
Description Is the value of dwc:minimumDepthInMeters a number that is less than or equal to the value of dwc:maximumDepthInMeters?
TestType Validation
Darwin Core Class dcterms:Location
Information Elements ActedUpon dwc:minimumDepthInMeters
dwc:maximumDepthInMeters
Information Elements Consulted
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:minimumDepthInMeters or dwc:maximumDepthInMeters is bdq:Empty, or if either are interpretable as not zero or a positive number; COMPLIANT if the value of dwc:minimumDepthInMeters is less than or equal to the value of dwc:maximumDepthInMeters; otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions MINDEPTH_LESSTHAN_MAXDEPTH
Parameter(s)
Source Authority
Specification Last Updated 2023-09-18
Examples [dwc:minimumDepthInMeters="0", dwc:maximumDepthInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:minimumDepthInMeters = dwc:maximumDepthInMeters"]
[dwc:minimumDepthInMeters="1", dwc:maximumDepthInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:minimumDepthInMeters > dwc:maximumDepthInMeters"]
Source ALA, GBIF, OBIS
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes
iDigBioBot commented 6 years ago

Comment by Paula Zermoglio (@pzermoglio) migrated from spreadsheet: This is assuming that depths are actually correct but transposed, rather than just one of them, maximum or minimum being just plainly wrong.

iDigBioBot commented 6 years ago

Comment by Paul Morris (@chicoreus) migrated from spreadsheet: Separate into a validation MIN_DEPTH_SHALLOWERTHAN_OR_EQ_MAX and an amendment MIN_MAX_DEPTHS_TRANSPOSED, to resolve the issue. There's a validation to find problematic depths, and an amendment which makes the explictit assumption that there is a transposition, make the transpostion, and leaves the consumer of the report free to decide whether or not to accept that assumption. A transposition ammendment could also be expected to be informed by a ocean depth model and only propose the transposition if it is reasonable for the location and geographic uncertainty. A nearshore depth where a minimum depth has an error in the form of a missing decimal point making it much larger than the maximum depth is a very plausible error on the line PZ considers.

iDigBioBot commented 6 years ago

Comment by Lee Belbin (@Tasilee) migrated from spreadsheet: Basically, the statement needs to be min max depths ok

iDigBioBot commented 6 years ago

Comment by Paul Morris (@chicoreus) migrated from spreadsheet: Split into separate Validation and Amendment, Validation=1, amendment needs more specification.

chicoreus commented 6 years ago

Splits have been accomplished. This test is now atomic so comments about splits have been satisfied.

chicoreus commented 5 years ago

Output Type is missing from the Field/Value table. @Tasilee please correct (looks like it should be Output Type = Validation) and review table for any other errors.

Tasilee commented 5 years ago

Thanks @chicoreus. Done.

Tasilee commented 1 year ago

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Is this one correct?

chicoreus commented 1 year ago

Both dwc:minimumDepthInMeters and dwc:maximumDepthInMeters are ActedUpon, as if NOT_COMPLIANT, the test isn't able to tell which is incorrect, so both need to be marked in the same way.