search

tdwg / bdq

Biodiversity Data Quality (BDQ) Interest Group
https://github.com/tdwg/bdq
43 stars 7 forks source link

TG2-AMENDMENT_DEGREEOFESTABLISHMENT_STANDARDIZED #276

Open ArthurChapman opened 7 months ago

ArthurChapman commented 7 months ago
TestField Value
GUID 74ef1034-e289-4596-b5b0-cde73796697d
Label AMENDMENT_DEGREEOFESTABLISHMENT_STANDARDIZED
Description Proposes an amendment to the value of dwc:degreeOfEstablishment using the bdq:sourceAuthority.
TestType Amendment
Darwin Core Class dwc:Occurrence
Information Elements ActedUpon dwc:degreeOfEstablishment
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:degreeOfEstablishment is bdq:Empty; AMENDED the value of dwc:degreeOfEstablishment if it can be unambiguously matched to a term in the bdq:sourceAuthority; otherwise NOT_AMENDED
Data Quality Dimension Conformance
Term-Actions DEGREEOFESTABLISHMENT_STANDARDIZED
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]}
Specification Last Updated 2024-04-16
Examples [dwc:degreeOfEstablishment="capt.": Response.status=AMENDED, Response.result=dwc:degreeOfEstablishment="captive", Response.comment="dwc:degreeOfEstablishment contains an interpretable value in the bdq:sourceAuthority"]
[dwc:degreeOfEstablishment="tree": Response.status=NOT_AMENDED, Response.result="", Response.comment="dwc:degreeOfEstablishment does not contain an interpretable value in the bdq:sourceAuthority"]
Source TG2
References
  • Darwin Core Maintenance Group (2021) Degree Of Establishment Controlled Vocabulary List of Terms. Biodiversity Information Standards (TDWG). http://rs.tdwg.org/dwc/doc/doe/
  • Groom et al. (2019) Improving Darwin Core for research and management of alien species. Biodiversity Information Science and Services 3: e38084. https://doi.org/10.3897/biss.3.38084
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes For reference, synonyms for values of dwc:degreeOfEstablishment can be found at https://registry.gbif.org/vocabulary/DegreeOfEstablishment/concepts.
ArthurChapman commented 7 months ago

Should be made CORE - see comments under #268

Tasilee commented 7 months ago

Removed Notes on Supplementary.

ArthurChapman commented 6 months ago

See my comment https://github.com/tdwg/bdq/issues/285#issuecomment-1951459629 under #285. I agree that this test should be CORE, but should include a note that it is expected that most results would return a INTERNAL_PREREQUISITES_NOT_MET result.

Tasilee commented 6 months ago

Are tests like #285, #278 and this test address the needs of a specific community and would therefore not fit the CORE requirement of "widely applicable"?

chicoreus commented 6 months ago

That's conflating CORE, the UseCase, research analysis of what organisms occurr where when, with the set of tests that we are providing as part of the standard (mature, but not supplementary).

On Mon, 19 Feb 2024 13:19:43 -0800 Lee Belbin @.***> wrote:

Are tests like #285, #278 and this test address the needs of a specific community and would therefore not fit the CORE requirement of "widely applicable"?

ArthurChapman commented 6 months ago

This (along with Pathway) has a major Use Case as set out in Groom et al. and is increasing being used in the Invasive Species community. Invasive Species are a big issue around the world and are one of the Key Issues in the Biodiversity Convention. So definitely "Widely applicable" These terms have not long been included in Darwin Core, but now that they are there is a large coordinated user community beginning to use them. This community is not specific as under the Convention on Biological Diversity, most countries and governments around the world are required to work on this issue. I would strongly push for CORE as I see no reason to exclude them as the test is well written and there are suitable Vocabularies and API.

@chicoreus - I have no idea what "mature" is - this should be CORE - there is a defined Use Case.

chicoreus commented 6 months ago

Source authority should be:

bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/]}

Tasilee commented 6 months ago

I agree @chicoreus - changing Source Authority from

bdq:sourceAuthority default = "Darwin Core degreeOfEstablishment" {[https://dwc.tdwg.org/list/#dwc_degreeOfEstablishment]} {dwc:degreeOfEstablishment vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]}

to

bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/]}

Tasilee commented 5 months ago

Should the Source Authority (API) be "https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts"?

tucotuco commented 5 months ago

I think https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts is OK as a source authority because it actually has an API, as long as it is understood that the actually vocabulary is maintained at https://dwc.tdwg.org/doe/ and the GBIF API is expected to remain up to date with that.

Tasilee commented 5 months ago

Fixed syntax on INTERNAL_PREREQUISITES_NOT_NET in Expected Response.

Tasilee commented 5 months ago

Changed Source Authority from

bdq:sourceAuthority default = "Darwin Core degreeOfEstablishment" {[https://dwc.tdwg.org/list/#dwc_degreeOfEstablishment]} {dwc:degreeOfEstablishment vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]}

to

bdq:sourceAuthority default = "GBIF DegreeOfEstablishment Vocabulary" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment]} {"dwc:degreeOfEstablishment vocabulary API" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]}

tucotuco commented 5 months ago

Source Authority should be

bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

Tasilee commented 5 months ago

Changed Source Authority from

bdq:sourceAuthority default = "GBIF DegreeOfEstablishment Vocabulary" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment]} {"dwc:degreeOfEstablishment vocabulary API" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]}

to

bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

tucotuco commented 5 months ago

Oops, my mistake. Should be

https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts

Tasilee commented 5 months ago

Corrected.

chicoreus commented 5 months ago

See https://github.com/tdwg/bdq/issues/275#issuecomment-2061845648

The GBIF API is only of partial help here, it does not provide the actual Controlled Values from the TDWG vocabulary, the values it has differ in case, implementations can use the GBIF API for its additional values, but need to align the case to match the actual Controlled Value from the TDWG vocabulary for the dwc: term values (GBIF API is sufficient for the dwciri term values).

Tasilee commented 4 months ago

GBIF vocabulary has now been aligned with Darwin Core. Thanks @timrobertson100