tdwg / bdq

Biodiversity Data Quality (BDQ) Interest Group
https://github.com/tdwg/bdq
43 stars 7 forks source link

TG2-VALIDATION_PATHWAY_STANDARD #277

Open ArthurChapman opened 7 months ago

ArthurChapman commented 7 months ago
TestField Value
GUID 5424e933-bee7-4125-839e-d8743ea69f93
Label VALIDATION_PATHWAY_STANDARD
Description Does the value of dwc:pathway occur in the bdq:sourceAuthority?
TestType Validation
Darwin Core Class dwc:Occurrence
Information Elements ActedUpon dwc:pathway
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:pathway is bdq:Empty; COMPLIANT if the value of dwc:pathway is in the bdq:sourceAuthority; otherwise NOT_COMPLIANT.
Data Quality Dimension Conformance
Term-Actions PATHWAY_STANDARD
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}
Specification Last Updated 2024-02-09
Examples [dwc:pathway="transportStowaway": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:pathway found in the bdq:sourceAuthority"]
[dwc:pathway="escapee": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:pathway not found in the bdq:sourceAuthority"]
Source TG2
References
  • Darwin Core Maintenance Group (2021) Pathway Controlled Vocabulary List of Terms. Biodiversity Information Standards (TDWG). https://dwc.tdwg.org/pw/
  • Groom et al. (2019) Improving Darwin Core for research and management of alien species. Biodiversity Information Science and Services 3: e38084 h.ttps://doi.org/10.3897/biss.3.38084
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes This test must return NOT_COMPLIANT if there is leading or trailing whitespace or there are leading or trailing non-printing characters.
ArthurChapman commented 7 months ago

Should be CORE see comments under #268

ArthurChapman commented 7 months ago

The four tests (#277, #278, #268, #269) should be CORE (I have discussed this with Lee). Some reasons are

chicoreus commented 7 months ago

Edited comment from "will fail" to the more explicit "This test must return NOT_COMPLIANT if there is leading or trailing whitespace or there are leading or trailing non-printing characters. "

chicoreus commented 7 months ago

Source authority should be:

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/]}

Tasilee commented 7 months ago

I agree @chicoreus - Changing Source Authority from

bdq:sourceAuthority default = "Darwin Core pathway" {[https://dwc.tdwg.org/list/#dwc_pathway]} {dwc:pathway vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

to

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/]}

Tasilee commented 6 months ago

Should the Source Authority (API) be "https://api.gbif.org/v1/vocabularies/Pathway/concepts"?

tucotuco commented 6 months ago

I think https://api.gbif.org/v1/vocabularies/Pathway/concepts is OK as a source authority because it actually has an API as long as it is understood that the actually vocabulary is maintained at https://dwc.tdwg.org/pw/ and the GBIF API is expected to remain up to date with that.

Tasilee commented 5 months ago

Changed Source Authority from

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

to

bdq:sourceAuthority default = "GBIF Pathway Vocabulary" [https://api.gbif.org/v1/vocabularies/Pathway]} {"dwc:pathway vocabulary API" [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

tucotuco commented 5 months ago

This was correct before the change. Darwin Core has the formal recommended vocabulary.

Tasilee commented 5 months ago

Reverted Source Authority

chicoreus commented 5 months ago

See https://github.com/tdwg/bdq/issues/275#issuecomment-2061845648

The GBIF API does not help here, it does not provide the actual Controlled Values from the TDWG vocabulary, the values it has differ in case.

Tasilee commented 4 months ago

GBIF vocabulary has now been aligned with Darwin Core. Thanks @timrobertson100