search

tdwg / bdq

Biodiversity Data Quality (BDQ) Interest Group
https://github.com/tdwg/bdq
43 stars 7 forks source link

TG2-AMENDMENT_PATHWAY_STANDARDIZED #278

Open ArthurChapman opened 5 months ago

ArthurChapman commented 5 months ago
TestField Value
GUID f9205977-f145-44f5-8cb9-e3e2e35ce908
Label AMENDMENT_PATHWAY_STANDARDIZED
Description Propose amendment to the value of dwc:pathway using bdq:sourceAuthority.
TestType Amendment
Darwin Core Class Occurrence
Information Elements ActedUpon dwc:pathway
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL PREREQUISITES_NOT_MET if dwc:pathway is EMPTY; AMENDED the value of dwc:pathway if it can be unambiguously matched to a term in bdq:sourceAuthority; otherwise NOT_AMENDED
Data Quality Dimension Conformance
Term-Actions PATHWAY_STANDARDIZED
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}
Specification Last Updated 2024-02-09
Examples [dwc:pathway="Stowaway on Truck": Response.status=AMENDED, Response.result=dwc:pathway="transportStowaway", Response.comment="dwc:pathway contains an interpretable value according to the bdq:sourceAuthority"]
[dwc:pathway="weed": Response.status=NOT_AMENDED, Response.result="", Response.comment="dwc:pathway does not contain an interpretable value according to the bdq:sourceAuthority"]
Source TG2
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes
ArthurChapman commented 5 months ago

Should be made CORE - See comments under #268.

Tasilee commented 5 months ago

I removed the Note re Supplementary.

ymgan commented 4 months ago

is this the sourceAuthority perhaps - https://dwc.tdwg.org/pw/ ?

chicoreus commented 4 months ago

Valuable, but not fitting the CORE use case as defined by TG3. Very likely applicable to regional checklist data. Almost certainly not populated in almost all occurrence data.

As with several other recently added related tests, needs a separate grouping to match a to be defined use case for checklist data.

ArthurChapman commented 4 months ago

Thanks @ymgan I meant to have this link in the References but I'd not changed after cut and paste. Corrected now

ArthurChapman commented 4 months ago

See my comment https://github.com/tdwg/bdq/issues/285#issuecomment-1951459629 under #285. I suggest that this test should be CORE, but should include a note that it is expected that most results would return a INTERNAL_PREREQUISITES_NOT_MET result.

Tasilee commented 4 months ago

If #285 and this test serve a specific community, it would fit Supplementary rather than CORE on the basis of "widely applicable"?

ArthurChapman commented 4 months ago

This (along with Degree of Establishment) has a major Use Case as set out in Groom et al. and is increasing being used in the Invasive Species community. Invasive Species are a big issue around the world and are one of the Key Issues in the Biodiversity Convention. So definitely "Widely applicable" These terms have not long been included in Darwin Core, but now that they are there is a large coordinated user community beginning to use them. This community is not specific as under the Convention on Biological Diversity, most countries and governments around the world are required to work on this issue. I would strongly push for CORE as I see no reason to exclude them as the test is well written and there are suitable Vocabularies and API.

ArthurChapman commented 4 months ago

The four tests (#277, #278, #268, #269) should be CORE (I have discussed this with Lee). Some reasons are

chicoreus commented 4 months ago

Source authority should be:

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/]}

Tasilee commented 4 months ago

Thanks @chicoreus - Changing Source Authority from

bdq:sourceAuthority default = "Darwin Core pathway" {[https://dwc.tdwg.org/list/#dwc_pathway]} {dwc:pathway vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

to

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/]}

Tasilee commented 3 months ago

Should the Source Authority (API) be "https://api.gbif.org/v1/vocabularies/Pathway/concepts"?

Tasilee commented 2 months ago

Changed Source Authority from

bdq:sourceAuthority default = "Pathway Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/pw/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

to

bdq:sourceAuthority default = "GBIF Pathway Vocabulary" [https://api.gbif.org/v1/vocabularies/Pathway]} {"dwc:pathway vocabulary API" [https://api.gbif.org/v1/vocabularies/Pathway/concepts]}

tucotuco commented 2 months ago

This was correct before the change. Darwin Core has the formal recommended vocabulary.

Tasilee commented 2 months ago

Reverted Source Authority

chicoreus commented 2 months ago

See https://github.com/tdwg/bdq/issues/275#issuecomment-2061845648

The GBIF API is only of partial help here, it does not provide the actual Controlled Values from the TDWG vocabulary, the values it has differ in case, implementations can use the GBIF API for its additional values, but need to align the case to match the actual Controlled Value from the TDWG vocabulary for the dwc: term values (GBIF API is sufficient for the dwciri term values).

Tasilee commented 1 month ago

GBIF vocabulary has now been aligned with Darwin Core. Thanks @timrobertson100