tdwg / bdq

Biodiversity Data Quality (BDQ) Interest Group
https://github.com/tdwg/bdq
43 stars 7 forks source link

TG2-VALIDATION_KINGDOM_FOUND #81

Open iDigBioBot opened 6 years ago

iDigBioBot commented 6 years ago
TestField Value
GUID 125b5493-052d-4a0d-a3e1-ed5bf792689e
Label VALIDATION_KINGDOM_FOUND
Description Does the value of dwc:kingdom occur at rank of Kingdom in the bdq:sourceAuthority?
TestType Validation
Darwin Core Class dwc:Taxon
Information Elements ActedUpon dwc:kingdom
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:kingdom is bdq:Empty; COMPLIANT if the value of dwc:kingdom is found as a value at the rank of kingdom in the bdq:sourceAuthority; otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions KINGDOM_FOUND
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}
Specification Last Updated 2023-09-18
Examples [dwc:kingdom="Animalia": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:kingdom has an equivalent at the rank of Kingdom in the bdq:sourceAuthority"]
[dwc:kingdom="Metazoa": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:kingdom does not strictly have an equivalent at the rank of Kingdom in the Parameterized Source Authority (Metazoa is synonym of Animalia)"]
Source GBIF GBIF Secretariat (2023) GBIF Backbone Taxonomy. Checklist dataset. https://doi.org/10.15468/39omei
References
Example Implementations (Mechanisms) Kurator/FilteredPush sci_name_qc Library
Link to Specification Source Code https://github.com/FilteredPush/sci_name_qc/blob/v1.1.2/src/main/java/org/filteredpush/qc/sciname/DwCSciNameDQ.java#L1390
Notes The purpose of this test is to check whether the value is a name that is a result of a nomenclatural act at this rank. This excludes unpublished names, misspellings and vernacular names. It is expected that the test will designate the source authority against to check. The same test might return distinct results when using distinct source authorities.
Tasilee commented 1 year ago

Restructured Parameter(s) and Source authority

Tasilee commented 1 year ago

Amended Source Authority values to align with @chicoreus syntax

From

bdq:sourceAuthority default = "GBIF Backbone Taxonomy" [https://doi.org/10.15468/39omei] | | | API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]

to

bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}

Tasilee commented 1 year ago

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"

Tasilee commented 7 months ago

Do we replace the current Source Authority with

bdq:sourceAuthority default = "GBIF Kingdom Vocabulary" [https://api.gbif.org/v1/vocabularies/Kingdom]} {"dwc:kingdom vocabulary API" [https://api.gbif.org/v1/vocabularies/Kingdom/concepts]}

Ditto for #90

?

tucotuco commented 7 months ago

It would be much simpler. I am in favor of that for kingdom.

Tasilee commented 7 months ago

Changed Source Authority from

bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}

to

bdq:sourceAuthority default = "GBIF Kingdom Vocabulary" [https://api.gbif.org/v1/vocabularies/Kingdom]} {"dwc:kingdom vocabulary API" [https://api.gbif.org/v1/vocabularies/Kingdom/concepts]}

chicoreus commented 7 months ago

I disagree. Much better, more consistent, and less complex if all of the higher taxonomy terms use the same base GBIF backbone taxonomy. We should revert the source authority to be consistent with the rest of the higher taxonomy terms:

bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}

Note that the phrasing of the specification expects that the source authority is a list of names at multiple ranks, not a specific vocabulary for this rank.

Tasilee commented 6 months ago

Changed Source Authority from

bdq:sourceAuthority default = "GBIF Kingdom Vocabulary" [https://api.gbif.org/v1/vocabularies/Kingdom]} {"dwc:kingdom vocabulary API" [https://api.gbif.org/v1/vocabularies/Kingdom/concepts]}

to

bdq:sourceAuthority default = "GBIF Backbone Taxonomy" {[https://doi.org/10.15468/39omei]} {API endpoint [https://api.gbif.org/v1/species?datasetKey=d7dddbf4-2cf0-4f39-9b2a-bb099caae36c&name=]}