Resolving the following issues labeled as community:consensus ->... - [merged]

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 00:46

_Merges new_termsconsensus -> development

Resolving the following issues labeled as community:consensus -> #3,#4,#7,#11,#12,#14,#15,#17,#18,#19,#20,#22,#23,#24,#28

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 14:15

added 1 commit

• e0a487f5 - Prettify json (indentation)

Compare with previous version

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on camtrap-package-profile.json line 16

          "description": "Organization name.",

I think this can remain Organization name, with the term itself being called title.

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on camtrap-package-profile.json line 36

As was suggested by @yliefting, I think taxon_id should be required as well.

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on camtrap-package-profile.json line 234

          "description": "Url of the source (reference list) of the `taxon_id`s in taxonomic coverage.",
          "example": "http://www.catalogueoflife.org/annual-checklist/2019/",

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on camtrap-package-profile.json line 240

          "description": "Internal attribute of data management system or data packages catalogue: platform name.",

The word name is more logical here, term name can remain.

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on deployments-table-schema.json line 219

      "description": "User defined tags associated with the deployment, as a valid JSON array.",

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on deployments-table-schema.json line 229

      "description": "Name or a unique identifier of the person who set up the camera for this deployment.",

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on deployments-table-schema.json line 226

@kbubnicki can you move this property right after end? That way tags and comments are closer together.

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on media-table-schema.json line 48

      "description": "Url or relative path to the multimedia file, respectively for externally hosted files or files that are part of this package. Additional information on how to access this file is provided in a package-level metadata.",

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on media-table-schema.json line 52

        "media/IMG0001.jpg"

Example of a shorter path that could be part of a data package

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on media-table-schema.json line 62

      "description": "Name of a multimedia file. This field is optional and supports cases where the file name is not a part of url provided in `file_path`.",

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on media-table-schema.json line 82

      "description": "EXIF data of the file, as valid a JSON object.",

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on observations-table-schema.json line 48

      "description": "Type of observation. All categories in this vocabulary have to be understandable from an AI point of view. `Undefined` describes classifications with a confidence level below some predefined threshold i.e. neither humans nor AI can say what was recorded.",

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on observations-table-schema.json line 180

I would move this one after classified_at, so that by comes right after method, but could be convinced otherwise.

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:46

Commented on observations-table-schema.json line 205

I understand that classified_at fits better with classified_by, but we don't use this terminology elsewhere for dates. Maybe classification_date is better after all?

[niconoe]

In GitLab by @peterdesmet on Sep 3, 2020, 15:50

@kbubnicki Thanks for implementing all this. See above for my review and suggestions.

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:30

Commented on camtrap-package-profile.json line 16

changed this line in version 3 of the diff

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:30

added 1 commit

• aa54866e - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:34

Commented on camtrap-package-profile.json line 36

Ok. I will change this and commit.

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:36

Commented on camtrap-package-profile.json line 234

changed this line in version 4 of the diff

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:36

added 1 commit

• ba126843 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:36

Commented on camtrap-package-profile.json line 240

changed this line in version 5 of the diff

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:36

added 1 commit

• a4e17391 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:36

Commented on deployments-table-schema.json line 219

changed this line in version 6 of the diff

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:36

added 1 commit

• 649fba91 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:37

Commented on deployments-table-schema.json line 229

changed this line in version 7 of the diff

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:37

added 1 commit

• f5169f15 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:38

Commented on deployments-table-schema.json line 226

Ok.

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 16:41

added 1 commit

• f77d4add - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 17:10

Commented on media-table-schema.json line 52

I think that this is not a good idea to suggest this kind of multimedia structure i.e. to keep all files in one folder as this can be really a large number (from tens/hundreds of thousands to millions per project).

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 17:13

Commented on media-table-schema.json line 62

Now I see that applying suggestion one-by-one automatically creates corresponding commits. From now I will be changing things locally and will send them via 1 aggregated commit.

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 18:05

Commented on observations-table-schema.json line 205

Changed to classification_date.

[niconoe]

In GitLab by @kbubnicki on Sep 3, 2020, 18:08

added 1 commit

• 2203926f - resolved review issues

Compare with previous version

[niconoe]

In GitLab by @peterdesmet on Sep 4, 2020, 10:12

Commented on media-table-schema.json line 52

Makes sense, but then I would drop project/collection as that is not necessarily a part you would include in a data package. So I would change to DEP0001/IMG0001.jpg.

[niconoe]

In GitLab by @peterdesmet on Sep 4, 2020, 10:14

Commented on media-table-schema.json line 62

I think it is possible to still accept and apply them one by one, but then squash all commits when merging. That way you don't need to manually copy the changes locally.

[niconoe]

In GitLab by @peterdesmet on Sep 4, 2020, 10:54

added 2 commits

• 7fc633df - Move setup_by right after start/end
• de125230 - Use order classification_method, _by, _date, _confidence

Compare with previous version

[niconoe]

In GitLab by @peterdesmet on Sep 4, 2020, 10:55

Made two changes in the order of terms. See https://gitlab.com/oscf/camtrap-package-schemas/-/merge_requests/9#note_407350170 for a suggested change to an example. After that this can be squashed and merged (although I am fine without the squash).

[niconoe]

In GitLab by @peterdesmet on Sep 4, 2020, 10:55

approved this merge request

[niconoe]

In GitLab by @peterdesmet on Sep 4, 2020, 10:55

unapproved this merge request

[niconoe]

In GitLab by @peterdesmet on Sep 4, 2020, 10:56

Is there a CI pipeline that kicks in when I approve?

[niconoe]

In GitLab by @kbubnicki on Sep 4, 2020, 11:30

Ok perfect! I will commit the changed example in a minute and directly merge this with the development branch, ok?

[niconoe]

In GitLab by @kbubnicki on Sep 4, 2020, 11:32

The pipeline starts after each single commit, I do not know how it works with approving

[niconoe]

In GitLab by @kbubnicki on Sep 4, 2020, 11:33

Commented on media-table-schema.json line 62

I see but the small problem is that the pipeline also starts after each single commit and gitlab has recently changed its policy and CI jobs are somehow limited (have to learn more about this)

[niconoe]

In GitLab by @kbubnicki on Sep 4, 2020, 11:34

Commented on media-table-schema.json line 52

True

[niconoe]

In GitLab by @kbubnicki on Sep 4, 2020, 11:38

added 1 commit

• d3e05657 - changed the example of relative file_path in media-table-schema.json

Compare with previous version

[niconoe]

In GitLab by @kbubnicki on Sep 4, 2020, 11:41

@peterdesmet I am going to merge this now, could you close/update all issues resolved with these changes?

[niconoe]

In GitLab by @kbubnicki on Sep 4, 2020, 11:42

resolved all threads

[niconoe]

In GitLab by @kbubnicki on Sep 4, 2020, 11:44

Ah, you still have to approve it :)

[niconoe]

In GitLab by @peterdesmet on Sep 4, 2020, 12:36

Ok!

[niconoe]

In GitLab by @peterdesmet on Sep 4, 2020, 12:36

approved this merge request