search

tdwright / contabs

Simple yet flexible tables for console apps.
MIT License
54 stars 20 forks source link

Wiki: Two small edits #62

Closed maxwell9999 closed 5 years ago

maxwell9999 commented 5 years ago

Hi @tdwright,

I was just going though the process of setup and trying to get a familiarity with contabs before I start work on Issue 54. I noticed two potential errors/typos in the wiki pages.

I tried to edit them myself and submit a change request, but it's not obvious how github lets you fork wiki pages since they aren't part of the repo itself. After a bit of searching on stack overflow, I not sure it's even possible in any easy way. Weird. If you do know how to do that easily, I'd be happy to know for the future.

Anyways, I thought I'd just list the two things I found as an issue: First, on page 2, styling, I believe the correct order for the three symbols in custom styles should be wall, floor, corner not floor, wall, corner. Second, on page 6, generating columns, after the example in "Basic usage" on step 2 it says input twice. I believe this should say "input type is float and the output type is int".

Hope that's helpful, let me know if I'm misunderstanding.

Best, Maxwell

tdwright commented 5 years ago

Hi @maxwell9999,

Thanks for flagging these.

FYI, the Wiki is currently locked (long story) so it's not your fault that you can't edit it directly. Not much of a "wiki" in its current state, I know, but seems to be for the best overall.

I've corrected both the errors you spotted:

Both are great catches. If you ever give up on development, consider a career in proofreading! Seriously though, if you notice anything else like this, please let me know.

Cheers, Tom