tdymel / DPSMate

A wow 1.12.1 combat analyzation tool
https://legacyplayers.com
GNU General Public License v3.0
92 stars 29 forks source link

Issues with parser and LUA errors #186

Closed Branszin closed 6 years ago

Branszin commented 6 years ago

DPSMate: 17: Event not parsed yet, inform Shino! => You perform Fishing.

DPSMate: 19: Event not parsed yet, inform Shino! => Saltpillar's Thorns were resisted by Blackhand Veteran

Interface\AddOns\DPSMate\DPSMate_DataBuilder.lua:2010: bad argument #1 to `strfind' (string expected, got nill)

This last error happens at odd times but it always happens when a party member dies.

scottgreenup commented 6 years ago
if strfind(target, "%s") then return end

I think target is nil, and needs to be checked first. Maybe inserting this line beforehand?

if target == nil then return end
tdymel commented 6 years ago

These events should not occour there...

scottgreenup commented 6 years ago

@Geigerkind Why did you close this ticket?

tdymel commented 6 years ago

Because I fixed this issue in the new build