tdymel / DPSMate

A wow 1.12.1 combat analyzation tool
https://legacyplayers.com
GNU General Public License v3.0
92 stars 29 forks source link

Nightfall-Weaponprocc doesn't appear when using a german client #205

Open 404-username opened 5 years ago

404-username commented 5 years ago

I noticed the weapon-proccs of my nightfall doesn't show up when i use a german wow client. When i use the english wow client, the proccs are listet correctly (Although it seems as it doesn't refer to single players and therefor only appears in the overview for all players). As i use my english client in raids to be able to contribute the data to legacyplayers it's no real problem to me, but on the long hand a fix would be nice. As the procc is marked as "to test" in the DPSMate_Parser.lua, it is maybe just not implemented in the localizations yet?

Nevertheless thanks for creating such a great tool!

tdymel commented 5 years ago

In order to fix it, I need some sample strings of the combat log.

404-username commented 5 years ago

Hey Geigerkind, I'm sorry I almost forgot my request here. As Nightfall proccs, the combat log shows the String:

Schwerer Kriegsgolem ist von Zauber-Verwundbarkeit betroffen.

As it fades, the log shows:

Zauber-Verwundbarkeit schwindet von Schwerer Kriegsgolem.

Just in case you need both strings ;)