tdymel / LegacyPlayersV3

Official repository of LegacyPlayers v3
GNU Affero General Public License v3.0
18 stars 25 forks source link

Fix pet parsing under some cases #152

Closed gfriloux closed 3 years ago

gfriloux commented 3 years ago

Describe the bug Some logs uploaded may fail to be parsed due to special cases.

The main issue is a panic on the thread running the parser:

thread '<unnamed>' panicked at 'attempt to add with overflow', Backend/src/modules/live_data_processor/tools/cbl_parser/wow_vanilla/parser.rs:1164:34
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

We end up with a GUID that is too long.

Another case is trying to find a summon that does not exist, due to combat log containing an empty string instead of the classical nil string.

To Reproduce

  1. Upload the given log : WoWCombatLog.txt.zip
  2. See error on backend

Expected behavior Parsing should not panic, and the raid should show up on the server.