rewrite language dictionary and add more tests

tdymel / LegacyPlayersV3

Official repository of LegacyPlayers v3

GNU Affero General Public License v3.0

18 stars 25 forks source link

rewrite language dictionary and add more tests #79

Closed llueder closed 4 years ago

llueder commented 4 years ago

dict impl behavior is unexpected when a key is registered, but has no translation for requested language. I would expect "Key [...] is not registered for language [...]", instead of "Value is empty for key [...] and language [...]". Might fix this myself if I find time...

tdymel commented 4 years ago

Vlt hätte man auch noch aus verschiedenen Regionalen Zeichen equiv. Klassen machen können, e.g. 1byte, 2byte, 3byte, 4byte zeichen etc.

llueder commented 4 years ago

Changed the dictionary implementation, pls have a look if it look rust-y to you. Technically, it is possible now to have empty translations.