This PR introduces new tests for testing the shortcut condition of try_parse_spell_cast() when parsing spell casts in the live data processor. One bug has been discovered and fixed in this PR with the test.
It is assumed that each spell cast may follow one of each damage/heal/threat event during a time window. Either when no more messages within the time window or all three events have arrived, the spell cast is considered complete, is returned and remove from the uncommitted events.
The bug effects the shortcut condition becoming true too early and thus discarding/ignoring following events that are associated with the spell cast.
This PR introduces new tests for testing the shortcut condition of
try_parse_spell_cast()when parsing spell casts in the live data processor. One bug has been discovered and fixed in this PR with the test.It is assumed that each spell cast may follow one of each damage/heal/threat event during a time window. Either when no more messages within the time window or all three events have arrived, the spell cast is considered complete, is returned and remove from the uncommitted events.
The bug effects the shortcut condition becoming true too early and thus discarding/ignoring following events that are associated with the spell cast.