te-online / timemanager

TimeManager App within Nextcloud to manage time tracking.
GNU Affero General Public License v3.0
103 stars 19 forks source link

Fatal Exception after Nextcloud 28.0.4 upgrade #163

Closed thomaskor closed 8 months ago

thomaskor commented 8 months ago

Hi, after update Nextcloud to 28.0.4 the App doesn't work.

Internal Server Error

The server encountered an internal error and was unable to complete your request. Please contact the server administrator if this error reappears multiple times, please include the technical details below in your report. More details can be found in the server log.

Extract from Log: "message":"Creation of dynamic property OCA\Extract\AppInfo\Application::$appName is deprecated at /var/www/nextcloud/apps/extract/lib/AppInfo

Thanks Thomas

NeurohrByteS commented 8 months ago

Same error from the logs: Timemanager doesn't work with Nextcloud 28.0.4

Timemanager InvalidParameterException Parameter "appName" for route "core.Js.getJs" must match "[^/]++" ("/apps" given) to generate a corresponding URL.Exception thrown: Symfony\Component\Routing\Exception\InvalidParameterException
te-online commented 8 months ago

Hey! I'm really sorry this is happening, I can reproduce it in my dev setup 😞

It seems like some part of the lookup for JS files in templates is broken in version 28.0.4 of Nextcloud. I commented on an issue in the Nextcloud/server repository and hope to get an answer soon.

In the meantime, on my dev container I was able to fix the Exception by doing these changes in the templates files.

If you can access and edit the app files on your server, please try if you can fix the issue by applying these changes and report back, if you have the time.

I still had issues activating the app via the UI, even after the changes, so I used occ. Before releasing a fix, app activation has to be fixed and testing has to be done with older versions of Nextcloud. But if this fix goes in the right direction, I hope to have a new version out to address this early next week.

It seems like Nextcloud's QA testing does not cover all scenarios, especially of apps using older mechanisms (that I cannot find a deprecation notice for, though) and that haven't been rewritten in the past years. 😿

Thank you for your patience 🙏

thomaskor commented 8 months ago

Hello Thomas, Thanks for the quick response. The workaround works. I'll close the ticket. Have a nice Easter Thomas