search

teacherc / spheri-app

Spheri is a simple web app that recommends a song based on your local weather
https://www.spheri.app
GNU General Public License v3.0
18 stars 3 forks source link

added button to request a new song with same zipcode #26

Closed jooossshhhh closed 1 year ago

jooossshhhh commented 1 year ago

The button pretty much just reloads the page using the zip code that was already inputted. Let me know if this solution will work for you or if you want me to come up with a different one.

jooossshhhh commented 1 year ago

Sounds good to me, @teacherc !

teacherc commented 1 year ago

@jooossshhhh Would it be possible for you to make the button the same size as the player (see image below - the player is off-center).

Also, any ideas for the copy (text) on the button? I think it could be a bit more descriptive (while staying short - 1-3 words, max).

Screen Shot 2022-12-15 at 12 21 26 AM
teacherc commented 1 year ago

@jooossshhhh Also, I think the button should sit above the edge of the card (there should be padding below it). Right now, it doesn't look like a button until I mouse over it. I think this is due to the sizing.

teacherc commented 1 year ago

@jooossshhhh FYI - You could also experiment with putting the button under the card. You can also change the dimensions. Have you tried doing very quick sketches (ovals and boxes)? Curious about your thoughts.

jooossshhhh commented 1 year ago

I can experiment with different locations, sizes, and paddings for the button when I get back to the computer with the code on it. I will send you some screenshots with the variations so you can decide on which one looks best. Thanks!

jooossshhhh commented 1 year ago

  1. Centered, outside card, same button display as 'Ask Spheri' image

  2. Centered, outside card, rectangular border image

  3. Inside card, rectangular border (turned off dark mode for this) image

  4. Same as #3, but uses all properties of 'Ask Spheri' button image

jooossshhhh commented 1 year ago

Here are a few different variations of the button, let me know if you see one you like or if you would like me to explore other options (or other button text options).

teacherc commented 1 year ago

@jooossshhhh Hello there! I just wanted to thank you for sending these options over. The end of the year has gotten much busier than I thought it would. I will respond by this Sunday with feedback (possibly earlier if I can get a chunk of free time). Happy holidays!

jooossshhhh commented 1 year ago

No rush, happy holidays!

teacherc commented 1 year ago

@jooossshhhh Hi! Happy New Year! I'm back and will take a look at this very soon. Hope you had a nice holiday season.

teacherc commented 1 year ago

Hello @jooossshhhh -

I just got a new job and am doing a little too much right now. I cannot integrate your changes until I tweak the release system to be a bit more stable (with GitHub Actions). I need to let this project go for now.

I apologize for the late response.