search

teacherfund / TeacherFund_next

A website to fund teachers discretionary spending because the government sucks at it
https://theteacherfund.com
MIT License
90 stars 87 forks source link

Implement medium screen design #100

Closed stripedpajamas closed 4 years ago

stripedpajamas commented 5 years ago

We have designs for medium sized screens:

Acceptance criteria:

jackpaulcollins commented 5 years ago

I can do this!

jackpaulcollins commented 5 years ago

@joelwass @stripedpajamas

I'm trying to understand how you have already made the page dynamic, and upon resizing the screen with the developer tools/React tab open I'm not seeing any classNames update. Can you point me in the right direction in how you're implementing these queries?

ghost commented 5 years ago

@jackpaulcollins FWIW, TeacherFund is using Tachyons for styling. All of the class names are always present no matter what the size of the screen is. Each class added might do something different for the responsiveness of the site.

DustinHaefele commented 5 years ago

I've been working through these today. Finished a few sections. I'll tinker with it tomorrow and see how far I can get and I'll put in a pull request for what I've done.

joelwass commented 5 years ago

Sweet thanks @DustinHaefele. Don't hesitate to put in a PR for a work in progress so we can assess as necessary

matthewbub commented 4 years ago

I'll be spending some time contributing to this today, if there's anything in particular let me know & I'll focus on that. Otherwise I'll be going from top to bottom

joelwass commented 4 years ago

awesome @hi-matbub ! i think one thing to note is people have contributed before so a lot of this could already be done, but any marginal improvement is always appreciated!