Closed misterbastean closed 1 year ago
@misterbastean is attempting to deploy a commit to the Teacherfund Team on Vercel.
A member of the Team first needs to authorize it.
This is awesome! Thanks @misterbastean we'll review sometime this week :)
Sure thing, happy to help.
Let me know if any changes are needed.
Best,
On Tue, Jun 1, 2021 at 12:48 PM Joel Wasserman @.***> wrote:
This is awesome! Thanks @misterbastean https://github.com/misterbastean we'll review sometime this week :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/teacherfund/TeacherFund_next/pull/203#issuecomment-852280072, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZMMQQUEUOOUIC55YDLDDTTQUFMNANCNFSM45XLMIQQ .
-- Joshua Bastean, Ed.D. IT Analyst and Designer Apple Learning Specialist Apple Teacher
@joelwass Updated PR. I'm new to contributing to OS on Github, so not sure I submitted correctly or if you get notified automatically, etc.
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/teacherfund/teacherfund/AY7EG6RkKPMTi2gZMkZD9EgLK4v5
✅ Preview: https://teacherfund-git-fork-misterbastean-update-contact-teacherfund1.vercel.app
@joelwass Updated PR. I'm new to contributing to OS on Github, so not sure I submitted correctly or if you get notified automatically, etc.
Yea the reviewers get emails when pushes are pushed :) thanks for the changes! looks good, i'm going to let it deploy to our preview branch so i can test it in the UI
Consoles removed, fixed typo (err => err.message). Thanks for catching those!
Thank you! I'm going to wait to merge until i figure out our CI issue but i'll merge when we get that figured out, thanks again!
Currently set to send emails to Mailtrap for testing, so need to update SMTP settings in /pages/api/contact.js as needed. Also added 2 environmental variables: EMAIL_USERNAME and EMAIL_PASSWORD, again for SMTP.