search

teacherfund / TeacherFund_next

A website to fund teachers discretionary spending because the government sucks at it
https://theteacherfund.com
MIT License
90 stars 87 forks source link

implement table for our work page with all payout and payment info #40

Closed joelwass closed 5 years ago

joelwass commented 5 years ago

create basic table with all info of cash inflows and outflows pulled from the API. this belongs as a component to be used in the ourwork.js page

pbrahmbhatt3 commented 5 years ago

Hi, I would like to work on this issue. However, I am new to this project. Any suggestions on where can I start from. @joelwass

joelwass commented 5 years ago

Hi @pbrahmbhatt3 ! Thanks for your interest!

I think this would be a good starter task, we just want to create a table component that will be able to show a list of data (columns being something like: type, donor/recipient, amount, and date) and then the rows being data fetched from the api (you don't have to worry about this yet it can be a separate task as the API side isn't done yet).

Long story short implementing a table component that could take in props for columns and rows, and used a jsx for loop to iterate over the rows, would be awesome! let me know if i can help further

jfeng43 commented 5 years ago

@joelwass I have some questions:

  1. since the API is not ready yet, should I write some static data for the table?
  2. what are the columns?
  3. how should the table look like?
  4. where should I put the table

It would be great if you can attach a draft of the new page so that I can understand better your goal.

joelwass commented 5 years ago

sure!

columns should be: "type", "donor/recipient", "amount", and "date". the table should be in chronological order with the top most rows being the most recent.

The table should be in it's own component and you can follow this guide to create just a simple css grid https://medium.com/evodeck/responsive-data-tables-with-css-grid-3c58ecf04723

joelwass commented 5 years ago

I know that's vague, we don't really have designs currently so we'll definitely have to revisit but we appreciate you helping out and getting this going!!!

pbrahmbhatt3 commented 5 years ago

Thank for your input. I am currently working on this issue @joelwass

joelwass commented 5 years ago

how can i help @pbrahmbhatt3

jfeng43 commented 5 years ago

@joelwass sounds good. I am looking into it.

jfeng43 commented 5 years ago

Hi @joelwass , I created this pull request: https://github.com/teacherfund/TeacherFund_next/pull/67

jfeng43 commented 5 years ago
table
jfeng43 commented 5 years ago

Please let me know your comment!

pbrahmbhatt3 commented 5 years ago

The table looks good. However, I suppose that the background image will be removed! As it would become very difficult to read data with this image at the back.

joelwass commented 5 years ago

Good point @pbrahmbhatt3 . i just merged @jfeng43 's table, we'd love styling help if you have bandwidth!