Implemented register component

teacherfund / TeacherFund_next

A website to fund teachers discretionary spending because the government sucks at it

https://theteacherfund.com

MIT License

90 stars 87 forks source link

Implemented register component #47

Closed trowacat closed 5 years ago

trowacat commented 5 years ago

This is in response to #3

Implemented a register component in the same style as the current sign in component.

The signInSignUp page is named in camel case which causes the page to be unreachable from the nav as it is currently configured. Not sure if this was intentional, therefore I left it.

joelwass commented 5 years ago

If possible I'd try to refactor the existing loginForm to accept an additional field (full name) and then just have the button do something different (register, which you can leave as a TODO since it's API related), instead of copy pasting the sign in form.

thoughts on that? I think it's just adding a "sign up" button to the login form, adding a "registering" field to state (boolean), and then toggling an extra input field (full name) based on the state of the component.

trowacat commented 5 years ago

@joelwass Thank you, I've made changes following your suggestion. Much better approach.