search

teacherfund / TeacherFund_next

A website to fund teachers discretionary spending because the government sucks at it
https://theteacherfund.com
MIT License
90 stars 87 forks source link

Toggle button enhancement for [issue #55] done! #60

Closed SahibArora closed 5 years ago

SahibArora commented 5 years ago

Hi there,

I have completed the enhancement, if you click the I'm a teacher button on the Home page, it will take you to the sign in page with I'm a teacher selected. I had to change the initial state for loginType to get the things working correctly. Please have a look and let me know if there is any issue in it. Thank you!

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

SahibArora commented 5 years ago

I did the requested changes, please give it a look. Thanks!

stripedpajamas commented 5 years ago

Looks great @SahibArora

One last thing-- as you can see, the Travis build is failing because of some linting issues. If you run npm run lint in the project, you should be able to see them. Here's a copy of the errors I see in Travis:

  /home/travis/build/teacherfund/TeacherFund_next/components/loginform.js:108:1: Trailing spaces not allowed.
  /home/travis/build/teacherfund/TeacherFund_next/components/loginform.js:109:3: Block must not be padded by blank lines.
  /home/travis/build/teacherfund/TeacherFund_next/components/nav.js:85:24: There should be no space before '='
  /home/travis/build/teacherfund/TeacherFund_next/components/nav.js:85:24: There should be no space after '='
  /home/travis/build/teacherfund/TeacherFund_next/components/nav.js:86:24: There should be no space before '='
  /home/travis/build/teacherfund/TeacherFund_next/components/nav.js:86:24: There should be no space after '='
  /home/travis/build/teacherfund/TeacherFund_next/pages/signinregister.js:14:40: A space is required before closing bracket
  /home/travis/build/teacherfund/TeacherFund_next/pages/signinregister.js:22:11: Trailing spaces not allowed.
joelwass commented 5 years ago

You can run npm run fix to get our linter to auto fix probably most of the issues @SahibArora

SahibArora commented 5 years ago

Lint errors - Fixed. Thanks for help!