wrap authenticated routes in a redirecter

teacherfund / TeacherFund_next

A website to fund teachers discretionary spending because the government sucks at it

https://theteacherfund.com

MIT License

90 stars 87 forks source link

wrap authenticated routes in a redirecter #69

Closed stripedpajamas closed 5 years ago

stripedpajamas commented 5 years ago

currently you can directly access /account (not sure what other pages assume a logged in state). it should instead redirect to either the home page or the login page. this might be able to be baked into the existing HOC.

jfeng43 commented 5 years ago

@stripedpajamas , which HOC component you suggest me to add the redirection logic to?

joelwass commented 5 years ago

This belongs in a route guard

https://stackoverflow.com/questions/50687015/route-guards-in-next-js-react
https://github.com/zeit/next.js/issues/153

stripedpajamas commented 5 years ago

Since account features have been removed, let's close this issue out. @joelwass and I will be revisiting the account architecture and once we have that nailed down we can create issues for implementation.