teacherfund / TeacherFund_next

A website to fund teachers discretionary spending because the government sucks at it
https://theteacherfund.com
MIT License
90 stars 87 forks source link

Make the stripe info input the same width as the other donate form divs #82

Closed joelwass closed 5 years ago

joelwass commented 5 years ago

Styling issue -> use taychons.io/docs

The width of the stripe input is slightly too large. using the taychon styles, align the width with the other inputs in components/donateForm.js

See screenshot for bug:

Screen Shot 2019-05-03 at 2 50 00 PM
thischrisblack commented 5 years ago

Hello, this is my first time trying to contribute to open source, and it looked like an issue I could take a shot at, so I forked, cloned, branched, and npm installed, and ran npm run dev. However, on my local machine, it looks very different. The stripe form is the same width as the rest, and there is no spacing between the input fields.

stripe

I'd love to pursue this and help out if you still need it. If so, can you tell me what I've done wrong? As I said, this is my first try ...

Thanks!

joelwass commented 5 years ago

Hi @thischrisblack ! Sorry about that, if you pull master you should see the issue (we just merged a major redesign). Note: the donate button in the nav is the only one that currently works, i'll fix the other one today but not sure i'll get around to it.

let me know if you have any other issues running the app and seeing the issue!

thischrisblack commented 5 years ago

Aha, there it is! Thank you. I'll get started.

joelwass commented 5 years ago

fixed in https://github.com/teacherfund/TeacherFund_next/pull/83