search

teacherfund / TeacherFund_next

A website to fund teachers discretionary spending because the government sucks at it
https://theteacherfund.com
MIT License
90 stars 87 forks source link

Heading color contrast update to meet accessibility standards. #98

Closed thomasean closed 5 years ago

thomasean commented 5 years ago

Small PR - The title and sub title in the hero image does have sufficient color contrast that meets WCAG 2 AA contrast ration thresholds. Changed the color to be white for better contrast.

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://teacherfund-git-fork-thomasean-fix-heading-color-contrast.teacherfund1.now.sh

joelwass commented 5 years ago

This is awesome but goes against our design. How can we solve this site wide without changing just the header and sub text color?

joelwass commented 5 years ago

Let me loop in our designer

thomasean commented 5 years ago

I recommend using Chromes built in Accessibility audit tool or a plugin called Axe (available for all major browsers). Run a quick scan and checkout the results! I'm happy to assist with site wide changes once you have a direction you'd like to go.

joelwass commented 5 years ago

Our designer gave the thumbs up! Thanks for bringing this to our attention @thomasean !