Verified mods not loaded

[Haocen2004]

here some logs for make sure mod verified

[06Dec2022 21:44:27.911] [ForkJoinPool.commonPool-worker-9/DEBUG] [RemoteSync/]: Verifying Xaeros_Minimap_22.11.1_Forge_1.18.2.jar
[06Dec2022 21:44:27.922] [ForkJoinPool.commonPool-worker-9/DEBUG] [RemoteSync/KeyStore]: Signature verified: DSA key 557FCB483BD04088, made on Tue Dec 06 21:32:13 CST 2022
[06Dec2022 21:44:27.922] [ForkJoinPool.commonPool-worker-9/DEBUG] [RemoteSync/]: Verification pass for Xaeros_Minimap_22.11.1_Forge_1.18.2.jar

but any mod is not loaded and modlist only forge itself (two mods)

Minecraft version : 1.18.2 Forge version : 40.1.86 mod version : 0.2.3

[3TUSK]

We need full debug.log in order to debug this. Please use a pastebin site upload your debug.log.

[Haocen2004]

https://pastebin.com/VfhWfNSe

[3TUSK]

Very strange. debug.log shows no error related to RemoteSync.

Which version of RemoteSync are you using?

May I use your mod list (it is printed out in debug.log) to test it locally?

[Haocen2004]

last release (0.2.3) modlist from vault hunter 3rd 0.0.2 and all required files on https://dev.hellocraft.xyz/mirror/vaultHunter/, include mod_list.json and cert file

[Haocen2004]

[08Dec2022 13:44:55.666] [main/DEBUG] [net.minecraftforge.fml.loading.moddiscovery.ModValidator/SCAN]: Found 2 mod files with 2 mods
[08Dec2022 13:44:55.668] [main/DEBUG] [cpw.mods.modlauncher.TransformationServiceDecorator/MODLAUNCHER]: End scan trigger - transformation service fml
[08Dec2022 13:44:55.674] [main/DEBUG] [net.minecraftforge.fml.loading.LanguageLoadingProvider/CORE]: Found 3 language providers
[08Dec2022 13:44:55.675] [main/DEBUG] [net.minecraftforge.fml.loading.LanguageLoadingProvider/CORE]: Found language provider minecraft, version 1.0
[08Dec2022 13:44:55.676] [main/DEBUG] [net.minecraftforge.fml.loading.LanguageLoadingProvider/CORE]: Found language provider lowcodefml, version 40
[08Dec2022 13:44:55.676] [main/DEBUG] [net.minecraftforge.fml.loading.LanguageLoadingProvider/CORE]: Found language provider javafml, version 40
[08Dec2022 13:44:55.679] [main/DEBUG] [net.minecraftforge.fml.loading.ModSorter/]: Configured system mods: [minecraft, forge]
[08Dec2022 13:44:55.680] [main/DEBUG] [net.minecraftforge.fml.loading.ModSorter/]: Found system mod: minecraft
[08Dec2022 13:44:55.680] [main/DEBUG] [net.minecraftforge.fml.loading.ModSorter/]: Found system mod: forge
[08Dec2022 13:44:55.683] [main/DEBUG] [net.minecraftforge.fml.loading.ModSorter/LOADING]: Found 0 mod requirements (0 mandatory, 0 optional)
[08Dec2022 13:44:55.683] [main/DEBUG] [net.minecraftforge.fml.loading.ModSorter/LOADING]: Found 0 mod requirements missing (0 mandatory, 0 optional)
[08Dec2022 13:44:55.879] [ForkJoinPool.commonPool-worker-1/DEBUG] [RemoteSync/Downloader]: Fetching remote resource https://dev.hellocraft.xyz/mirror/vaultHunter/modList.json
[08Dec2022 13:44:55.887] [ForkJoinPool.commonPool-worker-2/DEBUG] [RemoteSync/Downloader]: Trying to decide how to get https://dev.hellocraft.xyz/mirror/vaultHunter/AkashicTome-1.5-20.jar

I change the log level and i think that will help this part from https://dev.hellocraft.xyz/mirror/debug-1.log which set SCAN module log to accept and https://dev.hellocraft.xyz/mirror/debug.log set all modules log to accept

[Haocen2004]

overrided scanCandidates() will not be called in my local environment but overrided scanMods() can run correctly so I temporary add this on SyncedModLocator , it works

    @Override
    public List<IModFile> scanMods() {
        List<IModFile> result = new ArrayList<>();
        for (Optional<IModFile> optionalIModFile : scanCandidates().map(this::createMod).toList()) {
            optionalIModFile.map(result::add);
        }
        return result;
    }

it also on my fork repo

[3TUSK]

Your Forge version?

[Haocen2004]

40.1.86 i think I mentioned this at the beginning just after the screenshot

[3TUSK]

Forget that it was already mentioned. Apologize for that.

I vaguely remembered that there were some updates in ForgeSPI & FML that relate to mod discovery… I think this might explain something. I will have to find spare time to further debug this, however.

[Haocen2004]

ok I checked the forge source code, and when it loads a locator, it calls scanMods(). I think it's better to override this method. Only for my opinion.

[3TUSK]

https://github.com/teaconmc/RemoteSync/releases/tag/0.2.4

Should be fixed for now (according to my local test).

For now, 0.2.4 has a hard dependency on certain FML versions. I haven't got time to figure out the exact range yet, so make sure you are using latest Forge. The following facts are known:

• 0.2.4 works with Forge (FML) 40.1.86.
• 0.2.4 will NOT work with Forge (FML) whose version falls in range [41.0.39, ) due to ForgeSPI major version bump.

That said, 0.2.4 works with Forge (FML) whose version falls in range [?, 41.0.38] (I guess).