teads / TeadsSDK-iOS

Teads SDK for iOS - Premium branded "outstream" ads
https://support.teads.tv/support/solutions/articles/36000314785-ios-sdk-developer-guide
MIT License
27 stars 11 forks source link

Update TeadsSDK for Swift 5.1 & Xcode 11 #113

Closed richardneitzke closed 4 years ago

richardneitzke commented 5 years ago

Hi, we'd like to use the SDK with Swift 5.1 & Xcode 11 and were wondering when Teads will add support. It would be most helpful if you could provide a separate branch like you did for Xcode 10.2 😊

HugoGresse commented 5 years ago

Hi Richard, Teads SDK 2.4.5 is available for Swift 5.1 here This version has not been tested in production yet.

We'll switch the default pod on this version later on.

maxkattner commented 5 years ago

Hi Hugo, Is it possible to have this build also available on a branch in this repo? It would help our workflow very much when working on iOS 13 features if we only had to switch dependency branches. Of course we wouldn’t (and couldn’t) release with that version.

Thanks a lot for your assistance!

github-jeremy-grosjean commented 5 years ago

Hello guys, just made a branch with the framework compiled with the new XCode https://github.com/teads/TeadsSDK-iOS/tree/Swift5 Is that good for you?

richardneitzke commented 5 years ago

Hi Jeremy, Thank you for providing the branch, this makes things a lot easier for us. Looking forward to the full release.

richardneitzke commented 5 years ago

Hello @HugoGresse & @jeremygrosjean,

as Apple released the new Xcode 11 beta 3, we noticed that the binary on the branch is not compatible with the latest beta anymore. It would help us a lot if you could recompile the SDK with the latest Xcode beta and push it to the same branch as earlier.

Thank you for your help in this matter!

HugoGresse commented 5 years ago

Hi Richard, We'll provide an updated binary either this week or next week.

HugoGresse commented 5 years ago

We've updated the framework using XCode beta3, you can either find it on the branch xcode11b3 or here.

vincentsaluzzo commented 5 years ago

Hi @richardxyx

You can find a SDK build with Xcode 11b3 on branch xcode11b3.

richardneitzke commented 5 years ago

Thank you for your assistance @HugoGresse & @vincentsaluzz.

richardneitzke commented 5 years ago

Hello @HugoGresse, we would appreciate if you could provide us with an updated branch compiled with the latest Xcode beta so we can continue developing our app on the latest beta.

HugoGresse commented 5 years ago

Hi Richard, I'll loop with the team and get back to you.

HugoGresse commented 5 years ago

So we are waiting for the RC or the final XCode 11 to release any Teads framework supporting XCode 11. Let us know if you need anything more.

richardneitzke commented 5 years ago

Hi Hugo, we would greatly appreciate it if you could recompile and push to one of the existing branches (or a new one) so we can continue using the latest Xcode beta before the GM release in September.

oliviersanz commented 5 years ago

Hello @HugoGresse,

I'm an iOS developer working for Eurosport and we also really need an update of Teads framework so we can test that everything is ok with the latest XCode beta 5 (EDIT : now XCode beta 6) , before the GM release. Do you think it could be possible to release an update soon ?

Thank you !

vincentsaluzzo commented 5 years ago

Hello @oliviersanz & @richardxyx

We will take a look this week and come to you when it will ok.

Best

maxkattner commented 5 years ago

Hi @vincentsaluzzo, were you able to get everything running with beta 6? We would love to continue our efforts on preparing iOS 13 support and are kinda dependent on your regular beta updates. Let me know if you need any assistance.

Thank you!

laurent-humbert commented 5 years ago

With Xcode beta 6 I get

"Compiled module was created by an older version of the compiler; rebuild 'TeadsSDK' and try again:"

vincentsaluzzo commented 5 years ago

Hello there,

We will try to provide you a version with latest Xcode beta soon.

Best

vincentsaluzzo commented 5 years ago

You could find a version builded with β6 in https://github.com/teads/TeadsSDK-iOS/tree/xcode11b6

maxkattner commented 5 years ago

@vincentsaluzzo Thank you! However, we are still getting the error Compiled module was created by an older version of the compiler for the TeadsSDK. Can you please check if you really used the Swift 5.1 compiler shipped in Xcode 11 Beta 6?

vincentsaluzzo commented 5 years ago

My bad @maxkattner, I've upload the wrong SDK. I've just pushing the good one. Could you retry ?

maxkattner commented 5 years ago

Thank you @vincentsaluzzo, we can get back to the beta fun now. :)

tahirmt commented 5 years ago

Does it work with the GM seed?

laurent-humbert commented 5 years ago

Yes the built with b6 seems to compile and work fine with the Xcode 11 GM

andr3a88 commented 4 years ago

Hi, with the version xcode11b6 on Xcode 11.1 (11A1027) I still getting te error Module compiled with Swift 5.0.1 cannot be imported by the Swift 5.1 compiler

vincentsaluzzo commented 4 years ago

There is no need to use this version anymore. Last version is compiled with Xcode 11 and ready for Swift 5.1