Some patches for relay server functionality

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Do random testing of relayserver.
2. We will see some crashes and some times Not a stun packet error and packets 
get dropped by application.
3.

What is the expected output? What do you see instead?
We should not pad data indications packets (these packets are rtp/rtcp for 
audio/video). Because it might corrupt rtp frames. Even though we want to do 
it, it should be done using rtp padding extension and not normal padding. But 
this is not required.

There were some crahes while removing entry from map. We should not try to 
remove some invalid entries. It was a assert in original code. I just ignored 
the entry instead of crashing.

Also extended the relayserver_main.cc to be used with tcp and ssltcp.

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by chandaku...@gmail.com on 23 Mar 2012 at 7:03

Attachments:

• relayserver_main.cc
• relayserver.cc.patch
• stun.cc.patch

[GoogleCodeExporter]

Thanks for posting the patch. We found these problems too. 

First is the padding issue. Regarding this one, you might be right that one 
shouldn't pad the DATA attribute. Can somebody from libjingle confirm?

Second is a crash when adding a connection (here 
https://code.google.com/p/libjingle/source/browse/trunk/talk/p2p/base/relayserve
r.cc#522 ). In our case the removal of the ASSERT doesn't sound right. 

Didn't you have an assertion failure in AddConnection as well?

ovidiu

Original comment by ovidiud...@gmail.com on 23 Mar 2012 at 11:24

• Added labels: ****
• Removed labels: ****

[GoogleCodeExporter]

Original comment by juberti@google.com on 2 May 2012 at 10:11

• Added labels: ****
• Removed labels: ****